Ticket #1138 (closed defect: fixed)

Opened 4 months ago

Last modified 4 months ago

[PATCH] Resolve GLSL shader support compile errors

Reported by: Echelon9 Owned by:
Priority: Must Have Milestone: Alpha 9
Component: Core engine Keywords: GLSL, shaders
Cc:

Description

Changeset r10978 introduced GLSL support (​http://trac.wildfiregames.com/changeset/10978)

There is a mistake in the way the class CShaderProgramGLSL implements pglCreateShaderObjectARB(). pglCreateShaderObjectARB()'s return type is GLhandleARB, and thus m_Program, m_VertexShader and m_FragmentShader should be variables of type GLhandleARB.

Patch attached to fix this.

Attachments

t1138-GLSL-compile-fix.patch​ (778 bytes) - added by Echelon9 4 months ago.
Proposed fix for GLSL shader support compilation

Change History

Changed 4 months ago by Echelon9

Proposed fix for GLSL shader support compilation

comment:1 Changed 4 months ago by philip

  • Status changed from new to closed
  • Resolution set to fixed

(In [10983]) Be more consistent in using the ARB forms of functions. Fixes #1138, based on patch by Echelon9.

comment:2 Changed 4 months ago by historic_bruno

  • Keywords review, removed
Note: See TracTickets for help on using tickets.