Opened 12 years ago

Closed 10 years ago

Last modified 10 years ago

#1207 closed enhancement (fixed)

[PATCH] Trading Waypoints (2-parter)

Reported by: michael Owned by: leper
Priority: Nice to Have Milestone: Alpha 16
Component: UI & Simulation Keywords: patch
Cc: Patch:

Description (last modified by leper)

  1. Trade units can be tasked by the player to multiple waypoints on their journey, so that they avoide collisions, obstacles, or battlefields.

2. Trade units could waypoint between multiple markets/docks (3 or more), for a 10%-ish trading bonus for each additional market/dock. Dropped after some discussion (easily exploitable or if that is fixed hard to make obvious to the player)

Attachments (2)

2+-way-trade.patch (14.3 KB ) - added by leper 11 years ago.
Trade with more than two markets (WIP missing code to display proper stuff in the gui)
trade.diff (10.5 KB ) - added by mimo 10 years ago.

Download all attachments as: .zip

Change History (10)

by leper, 11 years ago

Attachment: 2+-way-trade.patch added

Trade with more than two markets (WIP missing code to display proper stuff in the gui)

comment:1 by leper, 11 years ago

Description: modified (diff)

I attached a patch that implements point 1, 2 and #1821 and #1822 (with a small remaining TODO in RallyPointCommands.js). There is some code missing in GuiInterface.js so that the tooltips display something, but after some discussion of point 2 in IRC we decided to remove that. I'm just attaching this patch in case someone wants to do something like that in the future.

comment:2 by historic_bruno, 11 years ago

Milestone: BacklogAlpha 15
Owner: set to leper

comment:3 by historic_bruno, 11 years ago

Keywords: patch added

comment:4 by historic_bruno, 11 years ago

Keywords: wip added; waypoints trading trader removed
Summary: Trading Waypoints (2-parter)[PATCH] Trading Waypoints (2-parter)

comment:5 by leper, 10 years ago

Component: Core engineUI & Simulation
Milestone: Alpha 15Alpha 16

comment:6 by mimo, 10 years ago

Keywords: review added; wip removed

Here is a patch for #1207, fixing at the same time #1821 and #1822. The patch is also a first step in the implementation of trading in formation (where we could have a column formation for traders), but this last feature is not completely implemented for the time being because of problems with the path finder for ship formations which prevent walking in formation for merchant ships.

by mimo, 10 years ago

Attachment: trade.diff added

comment:7 by mimo, 10 years ago

Resolution: fixed
Status: newclosed

In 14697:

allow the possibility to define route with waypoints when doing trade, fixes #1207, #1821 and #1822

comment:8 by mimo, 10 years ago

Keywords: review removed
Note: See TracTickets for help on using tickets.