[PATCH] Player should be able to train units over all buildings in a selection.

[michael]

Players should be able to train units in multiple buildings in a selection at the same time. For instance, if multiple Barracks are selected (usually via double click), then if the player clicks the "train spearman" button, a spearman should be added to the queues of all of the selected barracks. This removes unnecessary clicks and helps prevent carpal tunnel and tendonitis in players (known from experience).

[Spahbod]

These files contain some modifications from #1215 & #1209. So it is better to apply the patches in those tickets first before this to prevent unwanted errors.

[mammadori]

"This removes unnecessary clicks and helps prevent carpal tunnel and tendonitis in players (known from experience)."

Regarding this definition I think this could be related also with #1226, in 1226 there is the code to queue a unit in all selected buildings, in a positional (and easy to remember) way. ZXCV keys queue to 1234 kind of unit.

[Spahbod]

Simplified the patch according to instructions from Philip.

[leper]

Just noticed that this ticket is a dupe of #959 (maybe except the rally point setting, but that is already implemented).

[leper]

I took a look at your patch and you could improve it a bit:

• You should use FilterEntitiesList?(cmd.entities, player, controlAllUnits) in Commands.js instead of the if block.
• Remove entity and replace it with entities altogether. This way you can use the loop code for both cases in Commands.js

Apart from those points it is looking good. It would be good if you could try to provide a single patch file that only includes changes relevant to this ticket and maybe timestamp your patch.

[Spahbod]

Replying to leper:

I took a look at your patch and you could improve it a bit:

• You should use FilterEntitiesList?(cmd.entities, player, controlAllUnits) in Commands.js instead of the if block.
• Remove entity and replace it with entities altogether. This way you can use the loop code for both cases in Commands.js

Apart from those points it is looking good. It would be good if you could try to provide a single patch file that only includes changes relevant to this ticket and maybe timestamp your patch.

Sorry for the delay. About first point:That should work. but i did that because we need the player be able to control the first selected building (which is entity or entities[0]). But there is also a problem. It seems that FilterEntitiesList? can't be used in Command.js so I hardcoded the thing.

If we remove "entity" it causes the AI to stop training units. That needs a much broader change that needs quantumstate's approval.

[Spahbod]

Feel free to change the patch if necessary if i didn't return for so long.

[leper]

In 11592:

Allow training in all selected buildings. Fixes #1210.

[leper]

Thanks for your patch. I rewrote most of it as some of the code was changed by r11584 and my version adds the ability to add to batches if we have more than one building selected.