Ticket #1220 (closed defect: fixed)
[PATCH] Units stick to idle animation after destination target is constructed before reaching it
| Reported by: | Spahbod | Owned by: | mattlott |
|---|---|---|---|
| Priority: | Should Have | Milestone: | Alpha 10 |
| Component: | UI & Simulation | Keywords: | patch |
| Cc: | mk12360@… |
Description
When a building construction is finished, units that are walking to build it continue to move towards it while idle animation is being played.
Attachments
Change History
comment:1 Changed 15 months ago by k776
- Keywords unit, animation added; animation, buildings removed
- Component changed from Game engine to Simulation
comment:2 Changed 15 months ago by k776
- Summary changed from Animation problem with builders to Units stick to idle animation after destination target is constructed before reaching it
comment:3 Changed 14 months ago by mk12
- Cc mk12360@… added
- Owner set to mk12
- Status changed from new to assigned
Changed 14 months ago by mattlott
- Attachment 1220_StuckIdleAnimation.patch added
Switch to walking state if building completes while unit is still approaching
comment:6 Changed 14 months ago by mattlott
- Keywords animation, patch added; animation removed
- Summary changed from Units stick to idle animation after destination target is constructed before reaching it to [PATCH] Units stick to idle animation after destination target is constructed before reaching it
comment:8 Changed 14 months ago by vts
I can confirm the problem, and your patch appears to work well. I'll commit it soon. Thanks for contributing!
comment:9 Changed 14 months ago by vts
- Status changed from new to closed
- Resolution set to fixed
Fixed in r11775.
comment:10 follow-up: ↓ 14 Changed 14 months ago by gudo
mattlott: I'm working on compling a credit list for the game, and was wondering if you have a forum account? Most of the contributors do, so that's how I list them. If you don't though, I'll list your trac account.
comment:11 Changed 14 months ago by feneur
Could this patch be the reason for the below error?
ERROR: FinishOrder? called when order queue is empty
That occurs one time for each unit getting to a finished construction (but that was tasked to it before it was finished), and I don't remember seeing it before.
comment:12 Changed 14 months ago by leper
In 11776:
comment:13 Changed 14 months ago by leper
- Keywords review removed
The problem was that INDIVIDUAL.WALKING.MoveCompleted calls FinishOrder, but we already had an empty queue after the first call.
comment:14 in reply to: ↑ 10 Changed 14 months ago by mattlott
Replying to gudo:
mattlott: I'm working on compling a credit list for the game, and was wondering if you have a forum account? Most of the contributors do, so that's how I list them. If you don't though, I'll list your trac account.
I just created a forum account as well, username mattlott. If you need any more information, please let me know.
