Ticket #1256 (closed defect: fixed)

Opened 14 months ago

Last modified 13 months ago

[PATCH] My units and other units can be selected together

Reported by: JohnP4 Owned by: mk12
Priority: If Time Permits Milestone: Alpha 10
Component: UI & Simulation Keywords: patch simple select gui
Cc: mk12360@…

Description

If I select unit (or building), I can not additionally select with Shift another enemy or neutral, but not my unit (or building). If i select enemy or neutral unit, building or another not my object (resource for example), I can additionally select with Shift any my units (or building), but they do not execute my orders.

Game version: Alpha 9 Ides of March. My PC: Windows 7 Ultimate, 64-bit (Service Pack 1), AMD Phenom(tm) 9850 Quad-Core Processor 2.49 GHz, GeForce? GTX 260 (driver version 295.73), (two monitors 1920x1200, 1440x900), 4 Gb RAM.

Change History

comment:1 Changed 13 months ago by historic_bruno

  • Keywords simple gui added

You're right. The correct behavior (in my opinion) is that if you select another player's entity, in addition to not being able to give it orders, you shouldn't be able to add to that selection. Multiple selections would only be allowed for your own units (unless you use the Control All Units option in the developer overlay).

comment:2 Changed 13 months ago by mk12

  • Cc mk12360@… added
  • Owner set to mk12
  • Status changed from new to assigned

I'll do this. Seems to all be handled in the function addList of gui/session/selection.js.

comment:3 Changed 13 months ago by mk12

  • Keywords simple, select, added; select simple removed
  • Summary changed from unnecessary selection to My units and other units can be selected together

comment:4 Changed 13 months ago by mk12

  • Keywords patch, review, added
  • Summary changed from My units and other units can be selected together to [PATCH] My units and other units can be selected together
  • Milestone changed from Backlog to Alpha 10

Another one of those 20-seconds-to-review patches :-).

Changed 13 months ago by mk12

comment:5 Changed 13 months ago by leper

  • Status changed from assigned to closed
  • Resolution set to fixed

In 11608:

Don't add units to selection if the selected unit isn't owned by the player. Fixes #1256, based on patch by mk12.
Update AI API to Health changes.

comment:6 Changed 13 months ago by leper

  • Keywords patch simple select added; patch, review, simple, select, removed

Thanks for the patch.

Note: See TracTickets for help on using tickets.