Ticket #1291 (closed defect: fixed)

Opened 15 months ago

Last modified 12 months ago

[PATCH] Menu doesn't disappear automatically

Reported by: yualexey Owned by: Deiz
Priority: Should Have Milestone: Alpha 11
Component: UI & Simulation Keywords: menu simple patch
Cc:

Description

Menu doesn't disappear automatically: after you open it, even if you click anywhere on the map, it will not turn off.

Attachments

menu.jpg​ (488.8 KB) - added by yualexey 15 months ago.
close-menu.patch​ (553 bytes) - added by Deiz 13 months ago.

Change History

Changed 15 months ago by yualexey

comment:1 Changed 14 months ago by historic_bruno

  • Keywords simple added

The main menu already does something like this.

comment:2 Changed 13 months ago by Deiz

  • Keywords patch review added
  • Owner set to Deiz
  • Milestone changed from Backlog to Alpha 11

Here's a very simple fix. It mirrors the main menu functionality; clicking anywhere on the GUI won't close the menu, but clicking on the game world will.

Changed 13 months ago by Deiz

comment:3 Changed 13 months ago by Deiz

  • Status changed from new to assigned

comment:4 Changed 13 months ago by Deiz

  • Summary changed from Menu doesn't disappear automatically to [PATCH] Menu doesn't disappear automatically

comment:5 Changed 12 months ago by leper

  • Status changed from assigned to closed
  • Resolution set to fixed

In 12018:

Make menu disappear when interacting with the game world. Based on patch by Deiz. Fixes #1291.

comment:6 Changed 12 months ago by leper

  • Keywords review removed

Thanks for the patch. I moved the code to handleInputBeforeGui as selecting units (bandboxing) not closing the menu seemed strange, same with tasking units (right click).

Note: See TracTickets for help on using tickets.