Opened 12 years ago

Closed 11 years ago

Last modified 11 years ago

#1338 closed enhancement (fixed)

[PATCH] Add 'learn to play' item to in-game menu

Reported by: rdxi Owned by: ben
Priority: If Time Permits Milestone: Alpha 13
Component: UI & Simulation Keywords: patch
Cc: alfred.cl.wong.69@… Patch:

Description


Attachments (2)

learn_to_play_in_game.patch (1.4 KB ) - added by _vincent 12 years ago.
manualButton.patch (1.9 KB ) - added by Alfred Wong 11 years ago.

Download all attachments as: .zip

Change History (14)

comment:1 by historic_bruno, 12 years ago

Keywords: simple gui added

comment:2 by Alex, 12 years ago

Last edited 12 years ago by Alex (previous) (diff)

comment:3 by Alex, 12 years ago

'Doh! I seem to have misplaced the patch. I wanted to add this at ticket #1333 but ended up in another chrome tab. If someone could be so kind as to remove my attachment and comment, I would be grateful.

in reply to:  3 comment:4 by fcxSanya, 12 years ago

Replying to hapsky:

If someone could be so kind as to remove my attachment and comment, I would be grateful.

I removed the attachment, but it looks like it is impossible to delete comments and I see that you already replaced your original comment with empty text, so we will just leave it as is.

by _vincent, 12 years ago

Attachment: learn_to_play_in_game.patch added

comment:5 by _vincent, 12 years ago

Keywords: review added
Milestone: BacklogAlpha 12
Summary: Add 'learn to play' item to in-game menu[PATCH] Add 'learn to play' item to in-game menu

comment:6 by historic_bruno, 11 years ago

It's a minor issue, but I don't like how the game stays paused when the manual is closed.

comment:7 by Alfred Wong, 11 years ago

I think openManual() is more appropriate than learnToPlayButton() - submitting a patch soon. Also historic_bruno's point is valid, though I don't know how to fix it.

by Alfred Wong, 11 years ago

Attachment: manualButton.patch added

comment:8 by Alfred Wong, 11 years ago

Cc: alfred.cl.wong.69@… added

comment:9 by Kieran P, 11 years ago

Keywords: patch added; simple gui removed

comment:10 by Kieran P, 11 years ago

Milestone: Alpha 12Alpha 13
Priority: Nice to HaveIf Time Permits

comment:11 by ben, 11 years ago

Owner: set to ben
Resolution: fixed
Status: newclosed

In 13067:

Adds manual to in-game menu, based on patches by _vincent and grillaz. Fixes #1338

comment:12 by historic_bruno, 11 years ago

Keywords: review removed

Thanks for the patches! I added an optional callback function to the manual page, which is called when it closes (that's OK since they are in the same script context).

Note: See TracTickets for help on using tickets.