Ticket #1338 (closed enhancement: fixed)

Opened 14 months ago

Last modified 5 months ago

[PATCH] Add 'learn to play' item to in-game menu

Reported by: rdxi Owned by: ben
Priority: If Time Permits Milestone: Alpha 13
Component: UI & Simulation Keywords: patch
Cc: alfred.cl.wong.69@…

Description


Attachments

learn_to_play_in_game.patch (1.4 KB) - added by _vincent 9 months ago.
manualButton.patch (1.9 KB) - added by grillaz 7 months ago.

Change History

comment:1 Changed 14 months ago by historic_bruno

  • Keywords simple gui added

comment:2 Changed 13 months ago by hapsky

Last edited 13 months ago by hapsky (previous) (diff)

comment:3 follow-up: ↓ 4 Changed 13 months ago by hapsky

'Doh! I seem to have misplaced the patch. I wanted to add this at ticket #1333 but ended up in another chrome tab. If someone could be so kind as to remove my attachment and comment, I would be grateful.

comment:4 in reply to: ↑ 3 Changed 12 months ago by fcxSanya

Replying to hapsky:

If someone could be so kind as to remove my attachment and comment, I would be grateful.

I removed the attachment, but it looks like it is impossible to delete comments and I see that you already replaced your original comment with empty text, so we will just leave it as is.

Changed 9 months ago by _vincent

comment:5 Changed 9 months ago by _vincent

  • Keywords review added
  • Summary changed from Add 'learn to play' item to in-game menu to [PATCH] Add 'learn to play' item to in-game menu
  • Milestone changed from Backlog to Alpha 12

comment:6 Changed 8 months ago by historic_bruno

It's a minor issue, but I don't like how the game stays paused when the manual is closed.

comment:7 Changed 7 months ago by grillaz

I think openManual() is more appropriate than learnToPlayButton() - submitting a patch soon. Also historic_bruno's point is valid, though I don't know how to fix it.

Changed 7 months ago by grillaz

comment:8 Changed 7 months ago by grillaz

  • Cc alfred.cl.wong.69@… added

comment:9 Changed 7 months ago by k776

  • Keywords patch added; simple gui removed

comment:10 Changed 7 months ago by k776

  • Priority changed from Nice to Have to If Time Permits
  • Milestone changed from Alpha 12 to Alpha 13

comment:11 Changed 5 months ago by ben

  • Owner set to ben
  • Status changed from new to closed
  • Resolution set to fixed

In 13067:

Adds manual to in-game menu, based on patches by _vincent and grillaz. Fixes #1338

comment:12 Changed 5 months ago by historic_bruno

  • Keywords review removed

Thanks for the patches! I added an optional callback function to the manual page, which is called when it closes (that's OK since they are in the same script context).

Note: See TracTickets for help on using tickets.