Opened 12 years ago
Closed 12 years ago
#1427 closed enhancement (fixed)
[PATCH] Clarification of usage of s3tc
Reported by: | pcpa | Owned by: | |
---|---|---|---|
Priority: | If Time Permits | Milestone: | Alpha 11 |
Component: | Build & Packages | Keywords: | patch |
Cc: | Patch: |
Description
I made a 0ad package and requested it to be reviewed, for packing in Fedora, but would like to have some information about possible legal issues with s3tc.
For safety, I made a patch to disable nvtt and use the existing --without-nvtt option, so that it will not require the implementation in nvidia-texture-tools.
The information I would like to have is
o Once built without nvtt, it will only have the implementation in the
bundled but not built nvtt tree?
o The textures in 0ad-data are already compressed? From my understanding,
that would mean it could just send it to the graphics engine, but then, it would have issues, for example with things like team coloring, or is that just an alpha, and the color is in the model below it?
Thanks for any information, and many thanks for the great open source project!
Attachments (1)
Change History (5)
by , 12 years ago
Attachment: | 0ad-r11863-without-nvtt.patch added |
---|
comment:1 by , 12 years ago
Keywords: | patch review added |
---|---|
Milestone: | Backlog → Alpha 11 |
Summary: | Clarification of usage of s3tc → [PATCH] Clarification of usage of s3tc |
As far as I know (but don't take any of this for granted) s3tc is only used in nvtt, so your patch should work. The source code will still be there, but it won't be built thus it won't be present in the resulting binary (or rather there won't be any nvtt libs). (This is without regarding CompressedTextures)
The textures (in 0ad-data) are already converted (cached) during the run of the archive builder (which generates the public.zip).
Regarding the patch: I would use something like ...alse" ] && [ "$without_nvtt" = "false" ];
instead of using -a
.
On a related note: It would be nice if you referred to SubmittingPatches when doing so. It's also nice to leave a comment if you attach a patch to a ticket.
comment:3 by , 12 years ago
Keywords: | review removed |
---|
comment:4 by , 12 years ago
Resolution: | → fixed |
---|---|
Status: | new → closed |
0ad-r11863-without-nvtt.patch