Opened 12 years ago

Closed 12 years ago

#1462 closed enhancement (fixed)

[PATCH] Technologies should support folders

Reported by: michael Owned by: Jonathan Waller
Priority: Should Have Milestone: Alpha 11
Component: UI & Simulation Keywords: patch
Cc: Patch:

Description

I'd like technologies to support folders so that they can be divided by culture. I already have an example in the simulation/technologies/hellenes folder.

Example in the templates: 

  <ProductionQueue>
    <Technologies datatype="tokens">
	  hellenes/special_iphicratean_reforms
    </Technologies>
  </ProductionQueue>

Attachments (2)

recursive tech loading.2.patch​ (3.5 KB ) - added by Jonathan Waller 12 years ago.
Added error checking
recursive tech loading.patch​ (5.3 KB ) - added by Jonathan Waller 12 years ago.
Made recursiveness optional

Download all attachments as: .zip

Change History (8)

comment:1 by Kieran P, 12 years ago

Milestone: Backlog → Alpha 11

comment:2 by Kieran P, 12 years ago

Owner: set to Jonathan Waller

comment:3 by Jonathan Waller, 12 years ago

Keywords: patch review added
Summary: Technologies should support folders → [PATCH] Technologies should support folders

I have attached a patch. Basically I just switched the VFS function to one that could look recursively.

by Jonathan Waller, 12 years ago

Attachment: recursive tech loading.2.patch​ added

Added error checking

comment:4 by historic_bruno, 12 years ago

Keywords: patch, review → patch review

Can you make the recursion an option in Script_FindJSONFiles()?

by Jonathan Waller, 12 years ago

Attachment: recursive tech loading.patch​ added

Made recursiveness optional

comment:5 by historic_bruno, 12 years ago

Keywords: review removed

I've tested the latest patch by moving techs around in different folders and verifying they still work. All seems good, I say commit it :)

comment:6 by Jonathan Waller, 12 years ago

Resolution: → fixed
Status: new → closed

In 12440:

Added support for putting technologies in folders. Fixes #1462.

Note: See TracTickets for help on using tickets.