Ticket #1462 (closed enhancement: fixed)

Opened 12 months ago

Last modified 9 months ago

[PATCH] Technologies should support folders

Reported by: michael Owned by: quantumstate
Priority: Should Have Milestone: Alpha 11
Component: UI & Simulation Keywords: patch
Cc:

Description

I'd like technologies to support folders so that they can be divided by culture. I already have an example in the simulation/technologies/hellenes folder.

Example in the templates: 

  <ProductionQueue>
    <Technologies datatype="tokens">
	  hellenes/special_iphicratean_reforms
    </Technologies>
  </ProductionQueue>

Attachments

recursive tech loading.2.patch​ (3.5 KB) - added by quantumstate 10 months ago.
Added error checking
recursive tech loading.patch​ (5.3 KB) - added by quantumstate 10 months ago.
Made recursiveness optional

Change History

comment:1 Changed 12 months ago by k776

  • Milestone changed from Backlog to Alpha 11

comment:2 Changed 12 months ago by k776

  • Owner set to quantumstate

comment:3 Changed 10 months ago by quantumstate

  • Keywords patch, review added
  • Summary changed from Technologies should support folders to [PATCH] Technologies should support folders

I have attached a patch. Basically I just switched the VFS function to one that could look recursively.

Changed 10 months ago by quantumstate

Added error checking

comment:4 Changed 10 months ago by historic_bruno

  • Keywords patch added; patch, removed

Can you make the recursion an option in Script_FindJSONFiles()?

Changed 10 months ago by quantumstate

Made recursiveness optional

comment:5 Changed 9 months ago by historic_bruno

  • Keywords review removed

I've tested the latest patch by moving techs around in different folders and verifying they still work. All seems good, I say commit it :)

comment:6 Changed 9 months ago by quantumstate

  • Status changed from new to closed
  • Resolution set to fixed

In 12440:

Added support for putting technologies in folders. Fixes #1462.

Note: See TracTickets for help on using tickets.