#1712 closed defect (fixed)
[PATCH][ATLAS] Music and ambient sounds keep playing after simulation test
Reported by: | historic_bruno | Owned by: | trompetin17 |
---|---|---|---|
Priority: | Should Have | Milestone: | Alpha 18 |
Component: | Atlas editor | Keywords: | |
Cc: | Patch: |
Description
Once an Atlas simulation test is reset, any currently playing music and ambient sounds should stop.
Attachments (3)
Change History (25)
comment:1 by , 11 years ago
Milestone: | Backlog → Alpha 14 |
---|---|
Owner: | set to |
comment:2 by , 11 years ago
Milestone: | Alpha 14 → Alpha 15 |
---|
comment:3 by , 10 years ago
Milestone: | Alpha 15 → Alpha 16 |
---|
comment:4 by , 10 years ago
Milestone: | Alpha 16 → Alpha 17 |
---|
comment:5 by , 10 years ago
Owner: | removed |
---|
comment:6 by , 10 years ago
Keywords: | review patch added |
---|---|
Owner: | set to |
Summary: | [ATLAS] Music and ambient sounds keep playing after simulation test → [PATCH][ATLAS] Music and ambient sounds keep playing after simulation test |
comment:7 by , 10 years ago
comment:8 by , 10 years ago
Can you rename your methods to "pauseMusic"? We try to make a difference between sound and music (at least in the higher level, not in the lower level, as it all ends up with the same code anyway).
Sound is the collection of event sounds, selection sounds, shouts, ... while music is the background music.
comment:10 by , 10 years ago
Cc: | added |
---|
Hmm, looking closer at this patch, I'm not sure if the music should stop on pause too, or if the soundmanager should just be reset when the game is reset.
follow-up: 13 comment:12 by , 10 years ago
Keywords: | review removed |
---|
Hi trompetin, sorry for having taken so much time before looking back at your patch.
Concerning the code itself, don't forget to update the copyright date of the source files you modify.
About the functionality, I agree with sanderd17 saying that the music should not be just considered as "paused", but the sound manager should be reset when you click the "Reset" button. I don't think the music should stop when hitting "Pause".
Given that I saw you active recently, there is a chance you can write a new patch before release (feature freeze will happen on Sunday 14th and we'll have to review the patch before). Can you tell us if you think it's possible? If not, no worries, just postpone it to A18 and we'll be quicker at reviewing next time ;)
Thanks for your work on this!
comment:13 by , 10 years ago
DONE!, the music only "stop" when you press reset
Replying to Itms:
Hi trompetin, sorry for having taken so much time before looking back at your patch.
Concerning the code itself, don't forget to update the copyright date of the source files you modify.
About the functionality, I agree with sanderd17 saying that the music should not be just considered as "paused", but the sound manager should be reset when you click the "Reset" button. I don't think the music should stop when hitting "Pause".
Given that I saw you active recently, there is a chance you can write a new patch before release (feature freeze will happen on Sunday 14th and we'll have to review the patch before). Can you tell us if you think it's possible? If not, no worries, just postpone it to A18 and we'll be quicker at reviewing next time ;)
Thanks for your work on this!
comment:14 by , 10 years ago
Keywords: | review added |
---|
by , 10 years ago
Attachment: | 1712.patch added |
---|
comment:18 by , 10 years ago
Resolution: | fixed |
---|---|
Status: | closed → reopened |
If the simulation is running when you create a new map, the music keeps playing.
Choice 1 : Prevent the player from creating a new map when simulation is running
Choice 2 : Reset Sound State on Map Create.
comment:19 by , 9 years ago
Milestone: | Alpha 17 → Alpha 18 |
---|
by , 9 years ago
Attachment: | 1712_dic.diff added |
---|
comment:20 by , 9 years ago
Keywords: | review Atlas patch added |
---|
I fixed this one, please review 1712_dic.diff please
When you press reset, the music is fade to silent