Opened 11 years ago

Closed 11 years ago

Last modified 11 years ago

#1817 closed defect (fixed)

[PATCH] Settings checkboxes for developer overlay and silhouettes are out of sync if using hotkeys

Reported by: kingadami Owned by: kingadami
Priority: Nice to Have Milestone: Alpha 13
Component: UI & Simulation Keywords: patch
Cc: Patch:

Description

This is a nit picky thing I came across while working on another ticket.

If you use the hotkey for enabling the developer overlay the checkbox in the settings dialog does not get updated correctly.  The same goes for the silhouettes checkbox.

To reproduce enable the developer overlay by pressing the hotkey then open the settings dialog.  The checkbox is not checked even though the overlay is displayed.  If you only use the checkbox now for the overlay then it is backwards (Checking the box disables the overlay and unchecking enables it).  The silhouettes checkbox will get back in sync.

Attachments (1)

0adTicket_1817.patch (1.7 KB ) - added by kingadami 11 years ago.
Patch for fixing the ticket

Download all attachments as: .zip

Change History (6)

by kingadami, 11 years ago

Attachment: 0adTicket_1817.patch added

Patch for fixing the ticket

comment:1 by kingadami, 11 years ago

Keywords: patch review added
Owner: set to kingadami

comment:2 by Kieran P, 11 years ago

Milestone: BacklogAlpha 13

comment:3 by leper, 11 years ago

Resolution: fixed
Status: newclosed

In 13054:

Fix dicrepancy in the settings dialog when using hotkeys. Patch by kingadami. Fixes #1817.

comment:4 by leper, 11 years ago

Keywords: review removed
Summary: [PATCH]Settings checkboxes for developer overlay and silhouettes are out of sync if using hotkeys[PATCH] Settings checkboxes for developer overlay and silhouettes are out of sync if using hotkeys

Thanks for the patch.

comment:5 by historic_bruno, 11 years ago

Hmm that's another thing that could be nice to have in #1810, some kind of integration between UI, config and hotkeys.

Note: See TracTickets for help on using tickets.