Opened 11 years ago

Closed 11 years ago

Last modified 11 years ago

#1951 closed defect (wontfix)

VC++ 2005 build broken: missing __cpuidex

Reported by: historic_bruno Owned by:
Priority: Nice to Have Milestone:
Component: Core engine Keywords:
Cc: Jan Wassenberg Patch:

Description

Not necessarily something we'll choose to fix, but this ticket will document the problem. VC2008 and later include __cpuidex which we use for querying CPU info. Prior to r9891, we included our own asm implementations of that function for Linux and older versions of MSVC. That revision broke the VC2005 build.

Now we can chose to work around it somehow, fix it properly by adding back the asm for older compilers, or decide maybe it's time to drop VC2005 support anyway and let it fade into the sunset.

Change History (6)

comment:1 by historic_bruno, 11 years ago

Cc: Jan Wassenberg added

comment:2 by Jan Wassenberg, 11 years ago

Hi! My advice is to drop VC2005 and remove from Premake. It's been 8 years and there have been 3 subsequent major releases of the compiler. Old compilers might be required to support binary-old SDKs or something, but that's not the case for us. In particular, VC2010 is an improvement because it gets rid of the DLL manifest nightmare for the C runtime.

comment:3 by historic_bruno, 11 years ago

Hi Jan, that's how I feel as well :) Not only that but there are other problems getting VC++ 2005 Express to compile the game, the platform SDK has some conflicts like this:

second C linkage of overloaded function '_interlockedbittestandset' not allowed

every time we include intrin.h, which I solved by modifying an SDK header. I couldn't get my hands on a full copy of VC++ 2005 (it's missing from my university's downloads store), so I don't know if it also has that problem.

comment:4 by Jan Wassenberg, 11 years ago

No worries :) Can drop support for both versions of 2005. IF someone still wants and needs it, they can address these issues. Would advise closing this one.

comment:5 by historic_bruno, 11 years ago

Milestone: Backlog
Resolution: wontfix
Status: newclosed

comment:6 by leper, 11 years ago

In 13479:

Stop generating VS2005 project files. Refs #1951.

Note: See TracTickets for help on using tickets.