[ATLAS] Crash in CPatchRData::BuildWater - GeForce GTX 660 / win 7

[historic_bruno]

Alpha 14 release. User was working in Atlas and encountered this crash after zooming out. all fancy water and graphics settings were enabled.

Call stack:

>	pyrogenesis.exe!CPatchRData::BuildWater()  Line 1390 + 0x61 bytes	C++
 	pyrogenesis.exe!CPatchRData::CPatchRData(CPatch * patch=0x06e89154, CSimulation2 * simulation=0x227a6148)  Line 71	C++
 	pyrogenesis.exe!TerrainRenderer::Submit(CPatch * patch=0x1e5fdb50)  Line 126 + 0x22 bytes	C++
 	pyrogenesis.exe!CGameView::EnumerateObjects(const CFrustum & frustum={...}, SceneCollector * c=0x1e27029c)  Line 574	C++
 	pyrogenesis.exe!CRenderer::RenderScene(Scene & scene={...})  Line 1775	C++
 	pyrogenesis.exe!CGameView::Render()  Line 503 + 0x3c bytes	C++
 	pyrogenesis.exe!Render()  Line 222	C++
 	pyrogenesis.exe!AtlasViewGame::Render()  Line 258	C++
 	pyrogenesis.exe!RunEngine(void * data=0x0015f6bc)  Line 232	C++
 	pyrogenesis.exe!thread_start(void * param=0x003ba8f8)  Line 624 + 0x3 bytes	C++
 	msvcr90.dll!_callthreadstartex()  Line 348 + 0x6 bytes	C
 	msvcr90.dll!_threadstartex(void * ptd=0x1d55b340)  Line 326 + 0x5 bytes	C
 	kernel32.dll!@BaseThreadInitThunk@12()  + 0x12 bytes	
 	ntdll.dll!___RtlUserThreadStart@8()  + 0x27 bytes	
 	ntdll.dll!__RtlUserThreadStart@8()  + 0x1b bytes	

[wraitii]

I can't read crashlog dumps on Mac, is this a memory bad access error of some kind?

[historic_bruno]

Yes:

Unhandled exception at 0x0132a8bc (pyrogenesis.exe) in crashlog.dmp: 0xC0000005: Access violation reading location 0x10331100.

Another report here: http://www.wildfiregames.com/forum/index.php?showtopic=17610

[historic_bruno]

He got this same crash again in A15 RC. Not really clear on the steps to reproduce it, but it involves Atlas and playing with the camera and/or environment settings.

[wraitii]

In 14514:

Substantial speed-up of the foam generation code.
Remove waves for now as they were unsatisfactory.
Removes "shininess" as a water parameter as it was basically useless.
Add a button in Atlas to recompute water parameters so you can now see fog in Atlas.

Fixes #1743, #1803 (invalid)
Refs #1875, #2114, #48.

[wraitii]

In 15473:

Change the water texture to a new, bigger one, created in Blender (thanks to Enrique). Change settings so that they are more logical, yet allow reverting back to an even lower quality setting. Add a WIP high setting (with foam) which isn't finished yet.
Change the shader itself so that the effects look nicer and are more consistent across settings.
Rework the water mesh generation (simpler system). Fix a few issues.

May work oddly with Atlas since I haven't been able to compile yet.

Refs #1875 (maybe fix), Fixes #2077 (I'll assume it does), Fixes #2114 (assumption again), refs #48.