[PATCH] Allow resetting splash screen

[historic_bruno]

Currently, there is a boolean splashscreenenable config option that allows the user to not see the "splash screen" at startup. That's fine if the content of the splash screen never changes, but if we want to post an update in a new release, it would be more flexible to have an integer value to compare instead of a boolean. (Even more flexible would be a way to stream news and content into the game e.g. notifying of a new release, and maybe we should think about that for the future)

[Itms]

I chose an unsigned integer value, which seems more adapted to me and shall prevent any mistake (e.g. -1 to disable splashscreen).

[sanderd17]

I don't think you understood what the ticket says. We want a way to enable the splash screen on a new release. So, say a user has A13, and they disabled their splash screen, the config file looks like

splachscreen = 13

and the code checks for equality with 13. If it's equal, don't show a splash screen, if it's unequal, do show a splash screen. Now, when the user upgrades to A14, the code would check for equality with 14, so it would show the splashscreen again. When the user now clicks on "disable splashscreen", the config gets set to

splashscreen = 14

This way, with every release, the user will see the updated splash screen (which may show new information).

It should be bumped automatically with every new release, so you need to get the release version somewhere, and transform it to an integer that makes sense.

[Itms]

Indeed, I hadn't understood what was proposed in the ticket.

To implement that, I have written a system which allows to place the release version (and other information) into the code. Thus, I immediately used it to replace the sections of the GUI which needed this information. To "keep the patches reasonable" as said in the SubmittingPatches document, I post a ticket patching only my release information system : #2118

Here is the complete patch including changes to the splashscreen system, based on the new version data system.

[historic_bruno]

Thanks for working on this :) See the comments on #2118.

[Itms]

Waiting for the #2118 review to update the patch.

[fabio]

Replying to ​Itms:

What about just checking and keeping the date of the news file?

@fabio : I'm not sure what you meant : the aim of this patch is creating a place where to gather informations which shall be used again in the future development. It permits amongst other things fixing the splashcreen defect.

Sorry, I indeed commented on wrong bug (should be this, not ​#2118). I was meaning that instead to use a config option in default.cfg that have to be changed when the splashscreen get updated, the date of the spalshscreen (which is kept inside public.zip) could just be used and saved in user.cfg to detect if it got updated. This way there is no need to remember manually updating the splash screen version.

[Itms]

Replying to ​leper:

Sorry for taking so long with this, but the modification to #2116 shouldn't use the version number at all, just use a number which we can increment even between alpha releases if we want to do so.

So fabio and leper just think the same : I agree with you.

I've written a new patch ; there is no more link between this ticket and #2118.

[FeXoR]

If the use don't whant to see the splash screen he should have a choice to disable it!

Even if it's shown only once after an update (which would be my preferred settings) the user should not be "forced" to see it.

[Adrián Chaves]

Maybe we should show a Dismiss button (instead of OK/Accept), Remind Me Later (instead of Cancel) and let the check box say Never show notifications, so that:

• If you Dismiss a notification, you won’t see that notification again, but you will see any other notification.
• If you choose Remind Me Later, the same notification will be show the next time you open the game.
• If you choose Never show notification, you will never see notifications. We would need a way to enable them back, though; time to enable the Options page?

[Itms]

Good idea Gallaecio, here is my implementation.

I haven't added the Options page to my patch, since we should add to it the "fancywater" option for instance, etc... ; that should require another ticket.

[historic_bruno]

This isn't so much of a priority now that the fundraiser has ended. We just need to revert the special fundraiser splashscreen for A15.

[Itms]

This patch no longer applies to the current SVN. I am rewriting it, using the new implementations.

[Itms]

It appears to be really simple to change the splashscreen behavior with the new scripting implementation.

I think this is good for a future news streaming system!

[sanderd17]

In 15057:

Add the possibility to show the welcome screen on every update, next to the possibility to disable it completely. Patch by Itms, fixes #2116