[PATCH] Let structures deploy units without any cost directly after being built

[Palantius]

The idea is to allow structures to deploy units directly after being built. It should not require more resources.

Example of xml:

<ProductionQueue>
  <BatchTimeModifier>1.0</BatchTimeModifier>
  <Entities datatype="tokens">
    units/{civ}_support_female_citizen_house
  </Entities>
  <Technologies datatype="tokens">
    unlock_females_house
  </Technologies>
  <DirectDeployUnit datatype="tokens">
    units/{civ}_support_female_citizen_house
  </DirectDeployUnit>
  <DirectDeployCount>20</DirectDeployCount>
</ProductionQueue>

[sanderd17]

Code-wise it looks rather good, there's still a bit of copy-paste around lines 270. You could make the object to pass on beforehand, add the specific things, and then push it.

Something like (in pseudocode)

var queueElement = {
    id = this.nextID++
    ...
};

if (type == unit)
{
   queueElement.cost = cost;
   ...
}
else if (type == deploy)
{
    queueElement.cost = [];
    ...
}
this.queue.push(queueElement);

Also, I'm not sure if a unit shouldn't cost population. I think it shouldn't. When the unit dies, it would free a population slot, so there's a chance the population ends up negative.

[FeXoR]

Just referring to the negative population limit: This seams rather like a bug in the way population is counted...

[Imarok]

Move tickets to Simulation as UI & Simulation got some sub components.