Opened 11 years ago

Closed 10 years ago

Last modified 10 years ago

#2131 closed enhancement (fixed)

[PATCH] Improve the hero button when the hero is garrison.

Reported by: Marcio Owned by: peter
Priority: Nice to Have Milestone: Alpha 15
Component: UI & Simulation Keywords: Hero Button patch
Cc: Patch:

Description

http://www.wildfiregames.com/forum/index.php?showtopic=17616

the player can be confused where is the hero if they forget, he is garrison in a building or other.

Attachments (1)

hero.diff (1.3 KB ) - added by mimo 10 years ago.

Download all attachments as: .zip

Change History (8)

comment:1 by sanderd17, 11 years ago

I think this can be generalised to always show the garrisoning structure when a garrisoned unit is selected.

Like when you put your rams in a selection group, you garrison them into a ship, you need to select that ship to move your rams. While it would be nice if you could use the selection group to move the ship. And when rams are ungarrisoned, the group still refers to the rams like before.

comment:2 by mimo, 10 years ago

Keywords: patch review added
Summary: Improve the hero button when the hero is garrison.[PATCH] Improve the hero button when the hero is garrison.

here is a small patch which, when double-clicking on the hero button while the hero is garrisoned, selects and gives focus to its garrison holder. The code for such a selection is in an external function which should easily be reusable for the other cases mentionned by sanderd17 in comment 1.

by mimo, 10 years ago

Attachment: hero.diff added

comment:3 by peter, 10 years ago

Owner: set to peter
Resolution: fixed
Status: newclosed

In 13978:

Focus on the building a hero is garrisoned in when the hero button is double-clicked. Patch by mimo. Fixes #2131

comment:4 by alpha123, 10 years ago

Thanks for the patch.

comment:5 by leper, 10 years ago

Keywords: review removed
Milestone: BacklogAlpha 15

in reply to:  1 comment:6 by zweigousefen, 10 years ago

Replying to sanderd17:

I think this can be generalised to always show the garrisoning structure when a garrisoned unit is selected.

Like when you put your rams in a selection group, you garrison them into a ship, you need to select that ship to move your rams. While it would be nice if you could use the selection group to move the ship. And when rams are ungarrisoned, the group still refers to the rams like before.

What if part of the group is garrisoned ?

What if one parts of the group are garrisoned in different places ?

comment:7 by sanderd17, 10 years ago

If part of the group is garrisoned, don't select the buildings. If the entire group is garrisoned, but in different buildings, select all buildings.

It's quite arbitrary, but you have to do something (it's like pressing "follow" when your selection is very spread out.

Note: See TracTickets for help on using tickets.