[PATCH]Opening the developer overlay doesn't work in games started through the lobby

[leper]

Pressing Alt-D to open the dev overlay doesn't work in games that shouldn't be rated (non-1vs1 games) because the game was automatically configured locally as being rated.

To fix this issue we should first allow the player to enable/disable rating via a checkbox on the game setup screen and eventually make the box auto-disable itself when a game is not ratable.

[Josh]

This is really just that there should be a rated/unrated checkbox on the gamesetup screen. The complexity stems from the box automatically pre-configuring itself based on the ratability of the game in question.

It would be best to start with just adding the box and then working on preconfiguration in a separate ticket.

[pogisanpolo]

Added "unranked game" checkbox in multiplayer game setup.

[pogisanpolo]

I still haven't figured out how to actually tell the engine whether the game is actually ranked or not. So far this is simply an addition to the GUI. Trying to look through the documentation and source for the engine and I came across something called SetRankedGame. Not sure how to invoke that in javascript just yet but I'm still digging.

[Josh]

If I remember correctly, you would call it like "Engine.SetRankedGame(true);" to enable ranking and call it with false to disable ranking.

[scythetwirler]

Patch is incomplete, taking off review queue for now.

[scythetwirler]

Any progress on this, pogisanpolo?

[JoshuaJB]

In 14934:

Fix #2404. Rating auto-configure TODO (eg 2v2 games do not automatically show as being unrated). See #2276.

[Josh]

Remaining issues moved to #2516.

[elexis]

The c++ global g_rankedGame is still set to the default value (true) for rejoining players, so the ticket was only fixed assuming no rejoins, see #3550. So the wireframe hotkey also doesn't work in that case, and the lobby bot sends a wrong report as well. And the variable is also not used in other places where players can cheat with developer tools or exposed functions.