Opened 10 years ago

Closed 10 years ago

Last modified 7 years ago

#2329 closed enhancement (fixed)

[PATCH] Simplify and improve x86/amd64 CPU build flags

Reported by: fabio Owned by: fabio
Priority: Should Have Milestone: Alpha 17
Component: Build & Packages Keywords: patch
Cc: Patch:

Description

The attached patch does the following:

  • on amd64 removes the "-msse" flag, which is already enabled by default;
  • on x86 changes the flags from "-march=i686 -msse" to "-march=pentium3 -mtune=generic". This should also enable other CPU features like MMX, while keeping the same minimun supported CPU (Intel Pentium3 or AMD Athlon 4) previously required by "-msse".

Tested on x86 (Core2 Duo).

Attachments (1)

cpu-flags.diff (1.2 KB ) - added by fabio 10 years ago.
actual patch

Download all attachments as: .zip

Change History (8)

by fabio, 10 years ago

Attachment: cpu-flags.diff added

actual patch

comment:1 by fabio, 10 years ago

Milestone: Alpha 16Alpha 17

Better to postpone this after a new release.

comment:2 by Josh, 10 years ago

Keywords: reviewed added; review removed

It should be fine to commit this as soon as the Alpha 16 freeze is over.

comment:3 by fabio, 10 years ago

Owner: set to fabio
Resolution: fixed
Status: newclosed

In 15170:

Simplify and improve x86/amd64 CPU build flag

On amd64 removes the "-msse" flag, which is already
enabled by default.

On x86 changes the flags from "-march=i686 -msse" to
"-march=pentium3 -mtune=generic". This should also enable
other CPU features like MMX, while keeping the same
minimun supported CPU (Intel Pentium3 or AMD Athlon 4)
previously required by "-msse".

Fixes #2329.

comment:4 by Raymond, 10 years ago

Any performance improvements? Why not: "‘core2’ Intel Core 2 CPU with 64-bit extensions, MMX, SSE, SSE2, SSE3 and SSSE3 instruction set support." ? Maybe "SSE2, SSE3 and SSSE" (in core2) improve the performance? (https://gcc.gnu.org/onlinedocs/gcc-4.9.0/gcc/i386-and-x86-64-Options.html#i386-and-x86-64-Options)

Pentium III last produced until 2002. Note: SSE II support: 99 %; SSE III support: 95% (http://feedback.wildfiregames.com/static/cpucaps.html)

So increasing the requirements to Core2Duo CPU is not a problem.

Last edited 10 years ago by Raymond (previous) (diff)

comment:6 by sanderd17, 8 years ago

Keywords: reviewed patch → reviewed, patch

comment:7 by elexis, 7 years ago

Keywords: reviewed removed
Note: See TracTickets for help on using tickets.