[PATCH] Calculate visible patches only when frustum changes

[Lucas Malo Bélanger]

I looked at the GameView code for updating patches and I saw that the patches were calculated at each frame even if the frustum didn't change.

This patch bring a 15% speed enhancement on my laptop when the game is static.

[Lucas Malo Bélanger]

Gameview optimization

[Echelon9]

Thanks for the patch.

Perhaps worth clarifying in your description that the 15% noted improvement is in one subsystem. i.e. Given there are other hot paths every frame, users shouldn't expect to see a 15% improvement in the final metric (FPS) that the lay person considers the best measure of performance.

Still a good outcome if confirmed via testing!

[historic_bruno]

How did you measure the difference? Percentage claims are extremely vague and not very helpful. Also you should describe your test system and build environment (compiler, OS, etc.) and which map(s) you used. Apart from evaluating the patch itself, specific steps help to verify the claimed performance enhancements.

[Itms]

Hello lucas92, and sorry for leaving this patch aside for so long.

Maybe you're aware, but the rendering system has been updated by Philip` in r15445, so it makes your patch obsolete. However, maybe your changes are still relevant (we didn't managed to take a close look at your code, mostly because it isn't applicable anymore), so feel free to post a new version of this.

In the meantime, I remove this ticket from the review queue.

Thanks for your work so far!

[Stan]

Unasigning for lack of updates.