Text-Based Options are not Automatically Saved

[fabio]

Text-entry Game Options are not saved at all unless the user presses the enter key on their keyboard after inputting the new value.

For example, the following settings are not automatically saved:

• Audio Controls
• Chat Backlog

[scythetwirler]

All fields with numbers aren't saved yet. See line 140 - TODO of /gui/options/options.js.

[Josh]

Replying to scythetwirler:

All fields with numbers aren't saved yet. See line 140 - TODO of /gui/options/options.js.

That's not what that specific TODO is referring to, it more mentions a GUI engine slider element would be nice.

To save anything which uses a text field, you have to press enter after entering the new value. (counter-intuitive and non-ideal design)

Actually, the whole save settings bit is rather non-obvious. Clicking save does not actually apply the settings and cancel does not actually revert the settings. Clicking save just saves the settings to disk while cancel does nothing. All settings (unless noted otherwise) apply immediately.

[scythetwirler]

My mistake.

[Josh]

Fixing this (unfortunately) will be non-trivial.

[wraitii]

This sounds like the kind of annoyance we should try to get rid of, bumping back to A20.

[mimo]

In 17625:

allows changing options for one session without having to save them, fixes #3511
changes on text or number options are now detected without any need of typing Return, fixes #2451
graphic options (using the renderer type) are now properly saved when changed
sound options (using the function type) are still not saved

[elexis]

In 20091:

Allow the GUI to subscribe to text edit events to redeem three workarounds in the options page.

Differential Revision: ​https://code.wildfiregames.com/D860
Refs #2451, #3511, r17645 (registerChanges), rP17625 (onMouseLeave), rP10108 (onPress)
Reviewed By: Vladislav