Opened 10 years ago

Closed 8 years ago

Last modified 8 years ago

#2506 closed enhancement (fixed)

[PATCH] GLSL requires GenTangents

Reported by: Stan Owned by: fabio
Priority: Should Have Milestone: Alpha 20
Component: Core engine Keywords: patch
Cc: Patch:

Description (last modified by leper)

GLSL should not require GenTangents.

See discussion at http://irclogs.wildfiregames.com/2013-08-22-QuakeNet-%230ad-dev.log starting at 22:43.

Attachments (1)

merge-gentangents-preferglsl.patch (6.3 KB ) - added by fabio 8 years ago.
merge gentangents option into preferglsl

Download all attachments as: .zip

Change History (5)

comment:1 by leper, 10 years ago

Description: modified (diff)
Milestone: Alpha 16Backlog
Owner: leper removed
Priority: Release BlockerMust Have
Summary: glsl/gentangents are brokenGLSL requires GenTangents

comment:2 by fabio, 8 years ago

Keywords: review patch added
Milestone: BacklogAlpha 20
Owner: set to fabio
Priority: Must HaveShould Have
Status: newassigned
Summary: GLSL requires GenTangents[PATCH] GLSL requires GenTangents
Type: defectenhancement

As discussed in #3641 comment:2 the attached patch merges gentangents option into preferglsl.

As a follow-up we may eventually want to make glsl a third renderpath (other than fixed and shader).

by fabio, 8 years ago

merge gentangents option into preferglsl

comment:3 by wraitii, 8 years ago

Resolution: fixed
Status: assignedclosed

In 17325:

Tie tangent generation with preferGLSL setting for convenience since that setting was not really useful. Fixes #2506 . Patch by fabio.

comment:4 by fabio, 8 years ago

Keywords: review removed
Note: See TracTickets for help on using tickets.