Opened 10 years ago
Closed 9 years ago
#2540 closed defect (fixed)
[PATCH] Internationalize the in-game MENU button
Reported by: | Adrián Chaves | Owned by: | Jaison |
---|---|---|---|
Priority: | Should Have | Milestone: | Alpha 18 |
Component: | Internationalization & Localization | Keywords: | |
Cc: | Patch: |
Description
When you play a game, there is a menu button on the upper-right corner.
Currently, that button uses an image: http://trac.wildfiregames.com/browser/ps/trunk/binaries/data/mods/public/art/textures/ui/session/icons/menu.png
It should use actual text instead, and that text should be translated.
Attachments (6)
Change History (16)
comment:1 by , 10 years ago
comment:2 by , 10 years ago
Milestone: | Alpha 17 → Alpha 18 |
---|
comment:3 by , 9 years ago
I have appended two screenshots in which I have tried to make this button Translatable. Unless it works. Is it possible to tell me what font was used in the image to continue to keep these for the button in?
For questions you can find me in irc.
Greetings Jaison
PS. If it is ok and I have the font I set it finished.
comment:4 by , 9 years ago
Owner: | set to |
---|---|
Status: | new → assigned |
comment:5 by , 9 years ago
You should use the same font (and image) as the rest of the menu. That's what we do for the main menu, the in-game menu doesn't need to be different.
by , 9 years ago
Attachment: | button_menu.xml.patch added |
---|
comment:6 by , 9 years ago
I have added a patch with changes.
By me works in all Resolutions, can anyone test this,before assigned as [Patch].
Hope it is so true.
When asked, I am also on irc 0ad-dev.
Greetings Jaison
PS: I have included two versions: button_menu.xml.patch: StoneButtonFancy and button_menu.xml.2.patch in StoneButton style.
comment:7 by , 9 years ago
Summary: | Internationalize the in-game MENU button → [Patch] Internationalize the in-game MENU button |
---|
comment:8 by , 9 years ago
Summary: | [Patch] Internationalize the in-game MENU button → [PATCH] Internationalize the in-game MENU button |
---|
comment:9 by , 9 years ago
Thanks for the patch. We should avoid the ALL_CAPS menus, we're not Microsoft, and it's not consistent with the rest of the game :P Other than that, the patch looks good and works.
Definitely! If the exact font/effects used are important, we could perhaps extend the font builder to produce fonts like that. I have the feeling it's not that important.