Opened 10 years ago

Closed 9 years ago

#2540 closed defect (fixed)

[PATCH] Internationalize the in-game MENU button

Reported by: Adrián Chaves Owned by: Jaison
Priority: Should Have Milestone: Alpha 18
Component: Internationalization & Localization Keywords:
Cc: Patch:

Description

When you play a game, there is a menu button on the upper-right corner.

Currently, that button uses an image: http://trac.wildfiregames.com/browser/ps/trunk/binaries/data/mods/public/art/textures/ui/session/icons/menu.png

It should use actual text instead, and that text should be translated.

Attachments (6)

screenshot0007.png (1.3 MB ) - added by Jaison 9 years ago.
translate test1
screenshot0009.png (836.1 KB ) - added by Jaison 9 years ago.
translate test 2
button_menu.xml.patch (1.1 KB ) - added by Jaison 9 years ago.
button_menu.xml.2.patch (1.1 KB ) - added by Jaison 9 years ago.
with StoneButton Style
screenshot0019.png (1.4 MB ) - added by Jaison 9 years ago.
with StoneButton Style
screenshot0013.png (1.2 MB ) - added by Jaison 9 years ago.
with StoneButtonFancy Style (translated)

Change History (16)

comment:1 by historic_bruno, 10 years ago

Definitely! If the exact font/effects used are important, we could perhaps extend the font builder to produce fonts like that. I have the feeling it's not that important.

comment:2 by Itms, 10 years ago

Milestone: Alpha 17Alpha 18

by Jaison, 9 years ago

Attachment: screenshot0007.png added

translate test1

by Jaison, 9 years ago

Attachment: screenshot0009.png added

translate test 2

comment:3 by Jaison, 9 years ago

I have appended two screenshots in which I have tried to make this button Translatable. Unless it works. Is it possible to tell me what font was used in the image to continue to keep these for the button in?

For questions you can find me in irc.

Greetings Jaison

PS. If it is ok and I have the font I set it finished.

comment:4 by Jaison, 9 years ago

Owner: set to Jaison
Status: newassigned

comment:5 by historic_bruno, 9 years ago

You should use the same font (and image) as the rest of the menu. That's what we do for the main menu, the in-game menu doesn't need to be different.

Last edited 9 years ago by historic_bruno (previous) (diff)

by Jaison, 9 years ago

Attachment: button_menu.xml.patch added

comment:6 by Jaison, 9 years ago

I have added a patch with changes.

By me works in all Resolutions, can anyone test this,before assigned as [Patch].

Hope it is so true.

When asked, I am also on irc 0ad-dev.

Greetings Jaison

PS: I have included two versions: button_menu.xml.patch: StoneButtonFancy and button_menu.xml.2.patch in StoneButton style.

Last edited 9 years ago by Jaison (previous) (diff)

by Jaison, 9 years ago

Attachment: button_menu.xml.2.patch added

with StoneButton Style

by Jaison, 9 years ago

Attachment: screenshot0019.png added

with StoneButton Style

by Jaison, 9 years ago

Attachment: screenshot0013.png added

with StoneButtonFancy Style (translated)

comment:7 by Jaison, 9 years ago

Summary: Internationalize the in-game MENU button[Patch] Internationalize the in-game MENU button

comment:8 by Jaison, 9 years ago

Summary: [Patch] Internationalize the in-game MENU button[PATCH] Internationalize the in-game MENU button

comment:9 by historic_bruno, 9 years ago

Thanks for the patch. We should avoid the ALL_CAPS menus, we're not Microsoft, and it's not consistent with the rest of the game :P Other than that, the patch looks good and works.

comment:10 by ben, 9 years ago

Resolution: fixed
Status: assignedclosed

In 15906:

Internationalizes in-game menu text, based on patch by Jaison, fixes #2540.
Fixes inconsistent use of "Settings" to refer to game options dialog

Note: See TracTickets for help on using tickets.