Opened 9 years ago

Closed 9 years ago

Last modified 9 years ago

#3344 closed defect (fixed)

[PATCH] arm64 support for nvtt

Reported by: Martin Michlmayr Owned by: fabio
Priority: Nice to Have Milestone: Alpha 19
Component: Core engine Keywords: patch
Cc: Patch:

Description

nvtt doesn't build on arm64. I reported this upstream with a patch but have not received any reply yet: https://github.com/castano/nvidia-texture-tools/issues/224

If you want, you can apply the attached patch.

Attachments (1)

nvtt-arm64.patch (2.4 KB ) - added by Martin Michlmayr 9 years ago.

Download all attachments as: .zip

Change History (8)

by Martin Michlmayr, 9 years ago

Attachment: nvtt-arm64.patch added

comment:1 by Itms, 9 years ago

Hi! You should propose the upstream patch under the form of a github pull request instead of a patch I think. It would be easier for the maintainers to include it (and seeing the low number of open pull requests I think you could get an answer quite fast).

comment:2 by Martin Michlmayr, 9 years ago

Yeah, I know, but I didn't send a pull request because I had questions about the naming of NV_CPU_. But you're right, I should send one.

comment:4 by fabio, 9 years ago

Good, it doesn't apply, however, to nvtt 2.0.8-based currently in 0 A.D.. Could you backport the patch so that we can merge it in our copy? Thanks!

comment:5 by Martin Michlmayr, 9 years ago

Please see the attachment nvtt-arm64.patch​ to this Trac ticket. It's against 0AD SVN trunk.

comment:6 by fabio, 9 years ago

Owner: set to fabio
Resolution: fixed
Status: newclosed

In 16872:

Build fix for nvtt on arm64.

Patch by tbm.

Fixes #3344.

comment:7 by leper, 9 years ago

Keywords: review removed
Note: See TracTickets for help on using tickets.