Opened 9 years ago

Closed 3 years ago

Last modified 3 years ago

#3397 closed enhancement (fixed)

Option to select between generic and specific name or to select both

Reported by: Stan Owned by: Freagarach
Priority: Nice to Have Milestone: Alpha 25
Component: UI – Miscellaneous Keywords:
Cc: Patch: Phab:D2126

Description (last modified by Freagarach)

As stated in the discussion here :

http://wildfiregames.com/forum/index.php?s=541f7aea38c912e7f965f18c8f0cc04d&showtopic=20031

it would be nice to be able to switch between general and specific name, because it seems it confuse new players.

Feneur simply stated that instead of reading you could just pick the icons, however wowgetoffyourcellphone and OP thinks specific names should be off by default.

Attachments (3)

t3397_v1.patch (2.1 KB ) - added by Sergey Kushnirenko 8 years ago.
t3397_v2.patch (3.6 KB ) - added by Sergey Kushnirenko 8 years ago.
t3397_v3.patch (3.6 KB ) - added by Sergey Kushnirenko 8 years ago.

Download all attachments as: .zip

Change History (15)

comment:1 by elexis, 9 years ago

Keywords: simple added

I think noone will be so hardcore to only show the civ-specific names in the building / unit panel. Personally I don't see the need for a setting that hides the civ-specific names, as the generic names are always shown in parenthesis.

But if many new players would prefer that, maybe we could make a boolean setting that if enabled, only shows the generic names.

Wouldn't be hard to implement. See r16927 for an example of a new option.

In the template XML files, the names are given as:

    <GenericName>Commercial Port</GenericName>
    <SpecificName>Namel</SpecificName>

If you search for GenericName and SpecificName in *.js files, you will find all occurances that should be changed, if that option is active.

comment:2 by Stan, 9 years ago

I agree with you nonetheless I think a drop down could be nice. So everyone is happy ;)

in reply to:  description comment:3 by historic_bruno, 9 years ago

Replying to stanislas69:

however wowgetoffyourcellphone and OP thinks specific names should be off by default.

I don't agree with it being default, but I have always been in favor of this option, and similarly a "simple/basic" UI option with less information, and an "advanced/hardcore" option with lots of stats and whatnot. But for this ticket, it should be easy to add an option as elexis says.

The issue with a dropdown IIRC is the config screen doesn't currently support that.

Last edited 9 years ago by historic_bruno (previous) (diff)

by Sergey Kushnirenko, 8 years ago

Attachment: t3397_v1.patch added

comment:4 by Sergey Kushnirenko, 8 years ago

Keywords: review patch added
Milestone: BacklogAlpha 20
Summary: Option to select between generic and specific name or to select both[PATCH] Option to select between generic and specific name or to select both

by Sergey Kushnirenko, 8 years ago

Attachment: t3397_v2.patch added

by Sergey Kushnirenko, 8 years ago

Attachment: t3397_v3.patch added

comment:5 by Itms, 8 years ago

Milestone: Alpha 20Alpha 21

comment:6 by Itms, 8 years ago

Keywords: review removed

Hi, really sorry for the huge delay in reviewing :(

  • The option should not be a number but a boolean (either display specific names or don't)
  • Please add a description of the option and fix the missing space
  • I think the new getTemplateLabels function is not really wanted. It makes you rely on checks like if (specific != generic) which could cause problems. Better get the config value and take decisions based on it. You might have to hide GUI elements when the specific name is not wanted.

Thanks for your work so far!

comment:7 by elexis, 8 years ago

Milestone: Alpha 21Backlog
Type: taskenhancement

Backlogging due to lack of progress.

comment:8 by Imarok, 5 years ago

Component: UI & SimulationMisc. UI

Move tickets to Misc. UI as "UI & Simulation" got some sub components.

comment:9 by Freagarach, 4 years ago

Description: modified (diff)
Milestone: BacklogWork In Progress
Patch: Phab:D2126

comment:10 by Freagarach, 3 years ago

Owner: set to Freagarach
Resolution: fixed
Status: newclosed

In 25116:

Give option to switch between specific and/or generic entity names.

As requested on the forums (e.g. https://wildfiregames.com/forum/index.php?/topic/25202-transliteration-of-ancient-greek-into-english/&tab=comments#comment-378174).

Differential revision: D2126
Closes: #3397

comment:11 by Freagarach, 3 years ago

Keywords: simple patch removed
Milestone: Work In ProgressAlpha 25

comment:12 by Freagarach, 3 years ago

Summary: [PATCH] Option to select between generic and specific name or to select bothOption to select between generic and specific name or to select both
Note: See TracTickets for help on using tickets.