#3561 closed defect (fixed)
Summary screen - team totals wrong
Reported by: | elexis | Owned by: | Imarok |
---|---|---|---|
Priority: | Should Have | Milestone: | Alpha 21 |
Component: | UI & Simulation | Keywords: | |
Cc: | Patch: |
Description
If you have match with a lot of trade, you will see that the value of the team barter efficiency can become bigger than 100%. The percent-values are actually added instead of averaged.
For example if there is a team with two players and they both have 50% barter efficiency, then the team value should display 50% too instead of 100%, which is quite misleading.
Attachments (1)
Change History (12)
follow-up: 3 comment:1 by , 8 years ago
Summary: | Summary screen - team barter efficiency is summed up instead of averaged → Summary screen - team totals wrong |
---|
by , 8 years ago
Attachment: | t3561_fix_summary_screen_meh_WIP_v0.1.patch added |
---|
Not finished, but addresses most of the issues partially.
comment:3 by , 8 years ago
comment:4 by , 8 years ago
Milestone: | Alpha 19 → Backlog |
---|
comment:6 by , 8 years ago
Owner: | set to |
---|
comment:7 by , 8 years ago
Cc: | added |
---|
comment:8 by , 8 years ago
Cc: | removed |
---|
comment:9 by , 8 years ago
Replying to Imarok:
what is missing in this patch?
I'm not sure things are missing, it's just that it was a hacky patch that tried to fix issues that weren't issues :p (for instance the exploration total)
The patch is also clearly outdated. If you want to work on the issue I'd suggest to write a brand new patch (you can take some inspiration from elexis' one of course).
comment:11 by , 8 years ago
Keywords: | simple removed |
---|---|
Milestone: | Backlog → Alpha 21 |
There are actually multiple issues here:
Having infinite kill death ratio is not correct when having lost 0 units. Until we lost a unit, we don't know if the resulting value be close to 0 or close to infinity. It should display "-" instead. The team-total-value needs to take this into account correctly.Map-exploration total is completely wrong (35% + 36% = 56%?) (not wrong as areas explored by both players are not taken into account twice)