Opened 8 years ago

Closed 8 years ago

Last modified 8 years ago

#3655 closed defect (fixed)

[PATCH] Tooltip of the default hero capture aura hides the tooltip of other hero auras

Reported by: elexis Owned by: s0600204
Priority: Must Have Milestone: Alpha 20
Component: UI & Simulation Keywords: patch
Cc: s0600204 Patch:

Description

Many hero auras are not shown in the structure tree / tooltips anymore.

This is because both auras have the same <AuraName>Hero Aura</AuraName> tag.

See the carthaginian hero Hannibal Barca for a working example.

Attachments (2)

3655_auraTooltip.patch (2.8 KB ) - added by s0600204 8 years ago.
Proposed fix.
3655_wallsetAuras.patch (684 bytes ) - added by s0600204 8 years ago.
Additional patch to make wall auras display in the relevant tooltip in the structree

Download all attachments as: .zip

Change History (8)

comment:1 by leper, 8 years ago

Cc: s0600204 added

comment:2 by elexis, 8 years ago

Keywords: simple added
Milestone: BacklogAlpha 20
Priority: Should HaveMust Have

by s0600204, 8 years ago

Attachment: 3655_auraTooltip.patch added

Proposed fix.

comment:3 by s0600204, 8 years ago

Keywords: patch review added
Owner: set to s0600204
Status: newassigned
Summary: Tooltip of the default hero capture aura hides the tooltip of other hero auras[PATCH] Tooltip of the default hero capture aura hides the tooltip of other hero auras

by s0600204, 8 years ago

Attachment: 3655_wallsetAuras.patch added

Additional patch to make wall auras display in the relevant tooltip in the structree

comment:4 by elexis, 8 years ago

Resolution: fixed
Status: assignedclosed

In 17644:

Display all auras in the tooltips (even if there are some with an identical name). Patch by s0600204, fixes #3655.

Add an aura tooltip to the construction panel.
Remove duplicate tooltip code for the training panel.
Eliminate for-each and use the aura ID in GetTemplateDataHelper, since only that is a unique identifier.
Change the name from "Hero Aura" to "Garrisoned Capture Aura" for that aura that every hero has.

comment:5 by elexis, 8 years ago

Keywords: simple review removed

Thanks for the patches!

An example for a previously broken tooltip is the briton hero swordsmen cunobelin (having two auras with the name "Hero Aura").

The wall-auras should also be added, but add them to the construction panel as well and don't call loadStructure twice.

comment:6 by elexis, 8 years ago

In 17662:

Show the aura of city walls in the structure tree. Patch by s0600204, refs #3655.

Note: See TracTickets for help on using tickets.