Opened 8 years ago

Closed 8 years ago

#3812 closed defect (fixed)

[PATCH] Trade exploit

Reported by: fatherbushido Owned by: mimo
Priority: Must Have Milestone: Alpha 20
Component: UI & Simulation Keywords: patch
Cc: Patch:

Description

A confusion between markets stored in cmpTrader and those we actually trade with leads to a trade exploit.

With 3 markets A, B, C.

Click market A then shift right click B and shift right click C. Produce a trader in A. He will travel A - B and get the gain of A - C.

Attachments (3)

3812.diff​ (13.3 KB ) - added by fatherbushido 8 years ago.
3812.2.diff​ (13.3 KB ) - added by fatherbushido 8 years ago.
swap lines following mimo's advices
3812.3.diff​ (13.3 KB ) - added by fatherbushido 8 years ago.

Download all attachments as: .zip

Change History (5)

by fatherbushido, 8 years ago

Attachment: 3812.diff​ added

comment:1 by fatherbushido, 8 years ago

Summary: Trade exploit → [PATCH] Trade exploit

The attached patch is based on work of leper. It needs to be test and is still wip.

by fatherbushido, 8 years ago

Attachment: 3812.2.diff​ added

swap lines following mimo's advices

by fatherbushido, 8 years ago

Attachment: 3812.3.diff​ added

comment:2 by mimo, 8 years ago

Owner: set to mimo
Resolution: → fixed
Status: new → closed

In 17854:

fixes confusion between markets when doing trade, fixes #3812, patch by leper and fatherbushido

Note: See TracTickets for help on using tickets.