#4059 closed enhancement (fixed)
[PATCH] Batch size should be a user-configurable option
Reported by: | user1 | Owned by: | elexis |
---|---|---|---|
Priority: | Nice to Have | Milestone: | Alpha 21 |
Component: | UI & Simulation | Keywords: | patch |
Cc: | Patch: |
Description
I think it makes the most sense to expose this simply as a .cfg variable. That way we won't need to change anything in the gui.
Currently batchIncrementSize is a const in gui/session/input.js
Attachments (1)
Change History (6)
comment:1 by , 8 years ago
Keywords: | simple added |
---|---|
Milestone: | Alpha 22 → Backlog |
comment:2 by , 8 years ago
Keywords: | review patch added |
---|---|
Milestone: | Backlog → Alpha 21 |
Summary: | Batch size should be a user-configurable option → [PATCH] Batch size should be a user-configurable option |
by , 8 years ago
Attachment: | batchtrainingoption.patch added |
---|
comment:4 by , 8 years ago
Keywords: | simple review removed |
---|---|
Priority: | Should Have → Nice to Have |
- Added the
session
prefix to the config entry since the value only applies to the session. - Set the minimum to 1, so one can train any natural number of units.
- Set the maximum to 20. Maybe someone will use it in some cheat or deathmatch resources game.
- Added a comment to
default.cfg
and changed the tooltip a bit
Potential improvements if people like this:
- Setting it to 1 means that one unit will be trained both when not having the hotkey pressed and when having it pressed (while not having pressed the button before). Thought about changing the code so it would immediately start with 2 then, but it actually seems fine.
- Mabye we could also introduce a new hotkey, so that pressing it will add a batch of 1 while pressing shift will add a batch of 5. However going down that road will lead conflicts as nearly every key is already used for something. It could become optional.
Note:
See TracTickets
for help on using tickets.
GUI option can just be removed.