[PATCH] Rename CNetTurnManager to CTurnManager

[elexis]

The class CNetTurnManager is inherited for classes that simulate without being networked, for example CNetReplayTurnManager and CNetLocalTurnManager.

/**
 * Implementation of CNetTurnManager for offline games.
 */
class CNetLocalTurnManager : public CNetTurnManager

The name of the class suggests that networking code is involved, while it isn't necessarily.

The comment at the top of the file will have to be updated a bit, perhaps moved (but not degraded).

[Sandarac]

Not exactly sure how to reword the comment.

[Sandarac]

Rename all three classes.

[elexis]

The filepath source/network/CNetTurnManager.* seems questionable too. Should the classes be split across several files? Should the networked turnmanager be moved to NetClient.cpp and NetServer.cpp or moved to individual files inside network/, while moving the offline and parent class to source/ps, source/simulation2? (Or would it better to keep it all in one file? (likely not))

[echotangoecho]

Split the turnmanagers across files as suggested by elexis, remove the virtual functions OnSyncError and DisplayOOSError from the CTurnManager.

[echotangoecho]

Moves the function Hexify which occurs in multiple source files to ps/Util.h and removes the useless extern keyword from function declarations in that file.

[echotangoecho]

Change the previous patch to make the Hexify function use a range-based for loop.

[echotangoecho]

change for (char c : s) to for (const char& c : s).

[Itms]

In 18591:

Remove duplication of the Hexify function.
Remove the useless extern keyword from function declarations in ps/Util.h.

Patch by echotangoecho, refs #4095

[elexis]

WIP for some big rewrite ​https://github.com/echotangoecho/0ad/tree/turnmanager

[elexis]

Too few time remaining for this release.

[elexis]

Moving to the new WIP milestone.

[echotangoecho]

rebased patch

[elexis]

In 19165:

Split TurnManager classes into individual files per class. Patch by echotangoecho, fixes #4095.
Remove the "Net" prefix from the non-networked classes.
Use variadic macros and mark the client turnmanager as NONCOPYABLE.

Differential Revision: D16
Reviewed By: leper

[elexis]

Thanks for the branch, going through the revisions and updating the CPPSupport wiki page!