#4112 closed defect (fixed)
[PATCH] hide "I'm ready" button to observers
Reported by: | Andy Alt | Owned by: | echotangoecho |
---|---|---|---|
Priority: | Should Have | Milestone: | Alpha 21 |
Component: | UI & Simulation | Keywords: | patch |
Cc: | Patch: |
Description
On the game setup menu, the "I'm ready" button is useless to observers, and it's been suggested that it be hidden
Attachments (9)
Change History (16)
comment:1 by , 8 years ago
Keywords: | simple added |
---|
by , 8 years ago
Attachment: | hidereadybutton.patch added |
---|
comment:2 by , 8 years ago
Keywords: | rfc patch added |
---|---|
Summary: | hide "I'm ready" button to observers → [PATCH] hide "I'm ready" button to observers |
by , 8 years ago
Attachment: | hidereadybutton2.patch added |
---|
comment:3 by , 8 years ago
Seems to work now. However the hidden start button means it leaves some weird space. The buttons are right-aligned, so move the "back" button and cheatWarningText
to the right and increase the size of onscreenToolTip
accordingly.
(Another option would be to show some other control in case only for observers right there. Can't think of any though.)
comment:4 by , 8 years ago
Keywords: | rfc removed |
---|
by , 8 years ago
Attachment: | hidereadybutton3.patch added |
---|
comment:5 by , 8 years ago
Keywords: | rfc added |
---|---|
Milestone: | Backlog → Alpha 21 |
by , 8 years ago
Attachment: | hidereadybutton6.patch added |
---|
Use the suggestions made by elexis on IRC wrt the offset constant and the early return. Will likely need some more cleanup.
by , 8 years ago
Attachment: | hidereadybutton7.patch added |
---|
cheatWarningOffset was unused, pointed out by bb_ on IRC.
Note:
See TracTickets
for help on using tickets.
Try to fix some issues found by elexis.