Opened 14 years ago

Closed 13 years ago

Last modified 13 years ago

#428 closed task (fixed)

Generated Makefiles should not try to run wrong premake

Reported by: Philip Taylor Owned by:
Priority: Should Have Milestone: Alpha 7
Component: Core engine Keywords: simple
Cc: Patch:

Description

The Makefiles generated by Premake try to detect when the .lua file changed, and re-run premake. That doesn't work because it's not the right path (and it might try to run an incorrect version of Premake instead). Maybe it could be changed to use the right relative path, but it would probably be safer to just print a message telling the user to run update-workspaces.sh again.

(We already use a custom fork of Premake so it'd be adequate to just hard-code these changes into Premake's source.)

Change History (4)

comment:1 by (none), 13 years ago

Milestone: Unclassified

Milestone Unclassified deleted

comment:2 by Andrew, 13 years ago

Milestone: Backlog

comment:3 by Yves, 13 years ago

Resolution: fixed
Status: newclosed

This has been removed a long time ago and premake4 doesn't do it anymore. I think that's the best solution. http://trac.wildfiregames.com/changeset/7218

comment:4 by Philip Taylor, 13 years ago

Milestone: BacklogAlpha 7

r7218 only changed what happens when building Premake itself, not what happens when building the game (which this ticket was about). But probably best to close this ticket anyway since premake4 makes it irrelevant.

Note: See TracTickets for help on using tickets.