Ticket #428 (closed task: fixed)

Opened 4 years ago

Last modified 23 months ago

Generated Makefiles should not try to run wrong premake

Reported by: Philip Owned by:
Priority: Should Have Milestone: Alpha 7
Component: Core engine Keywords: simple
Cc:

Description

The Makefiles generated by Premake try to detect when the .lua file changed, and re-run premake. That doesn't work because it's not the right path (and it might try to run an incorrect version of Premake instead). Maybe it could be changed to use the right relative path, but it would probably be safer to just print a message telling the user to run update-workspaces.sh again.

(We already use a custom fork of Premake so it'd be adequate to just hard-code these changes into Premake's source.)

Change History

comment:1 Changed 3 years ago by anonymous

  • Milestone Unclassified deleted

Milestone Unclassified deleted

comment:2 Changed 3 years ago by wacko

  • Milestone set to Backlog

comment:3 Changed 23 months ago by Yves

  • Status changed from new to closed
  • Resolution set to fixed

This has been removed a long time ago and premake4 doesn't do it anymore. I think that's the best solution. http://trac.wildfiregames.com/changeset/7218

comment:4 Changed 23 months ago by Philip

  • Milestone changed from Backlog to Alpha 7

r7218 only changed what happens when building Premake itself, not what happens when building the game (which this ticket was about). But probably best to close this ticket anyway since premake4 makes it irrelevant.

Note: See TracTickets for help on using tickets.