#4308 closed enhancement (fixed)
[PATCH] Show resource gifts to all allies
| Reported by: | echotangoecho | Owned by: | |
|---|---|---|---|
| Priority: | Nice to Have | Milestone: | Alpha 22 |
| Component: | UI & Simulation | Keywords: | patch |
| Cc: | Patch: |
Description
Currently, chat messages about resource gifts are shown only to the player who receives them and to observers. It would be nice if they where shown to allied players as well.
Attachments (4)
Change History (15)
comment:1 by , 7 years ago
| Keywords: | simple added |
|---|---|
| Type: | defect → enhancement |
comment:2 by , 7 years ago
| Keywords: | rfc patch added |
|---|---|
| Milestone: | Backlog → Alpha 22 |
| Summary: | Show resource gifts to all allies → [PATCH] Show resource gifts to all allies |
by , 7 years ago
| Attachment: | messages.js.patch added |
|---|
by , 7 years ago
| Attachment: | see_ally_tributes_v1.1.patch added |
|---|
Tributes sent to or from allies are shown.
by , 7 years ago
| Attachment: | see_tributes_between_allies_v1.1.patch added |
|---|
Tributes between allied players will be shown (but not from an ally to an enemy, and also not from an enemy to an ally).
comment:3 by , 7 years ago
I guess before deceiding to do that you have thought at:
- isn't it too verbose ?
- in diplomacy lms ffa game (dunno how to call that), perhaps you want to give sneaky tribute to an ally and don't want to inform your other allies (you can also imagine complex ally ennemy graph (what happens for example when you give ress to an ennemy of your ally ?)
(I have from my own pov no preference between showing those messages or not).
comment:4 by , 7 years ago
Those are exactly the 2 points of doubt that prevented me from committing this patch.
After discussing with Imarok, we thought it might be better to either reuse the notification panel in the middle of the screen (that currently shows the wonder, last man standing and building placement notifications), or have a separate panel below the chat (or somewhere else) where these game notifications (barter, tribute, attack, diplomacy, resign, won...) are shown. The latter would solve the spam issue probably entirely.
While we could decide that allies ought to share that information (like they share line of sight), the notification could only be shown if teams are locked to allow more freedom in diplomacy games and more teamplay in team-games.
The new panel can certainly be done in a separate patch, perhaps ticket.
by , 7 years ago
| Attachment: | see_tributes_between_allies_v1.2.patch added |
|---|
Maybe we should split the chat and notification messages prior to considering to commit this?
comment:5 by , 7 years ago
| Keywords: | simple removed |
|---|
comment:7 by , 7 years ago
The patch has been ported to Phabricator. https://code.wildfiregames.com/D106
comment:8 by , 7 years ago
| Keywords: | rfc removed |
|---|
comment:9 by , 7 years ago
| Resolution: | → fixed |
|---|---|
| Status: | new → closed |
comment:10 by , 7 years ago
| Milestone: | Work In Progress → Alpha 22 |
|---|
Fixed by r19233, thanks for the proposal and the patch! Was quite an act putting that together, but now it avoids unneeded team chat communication while not conflicting with diplomacy mode and also addresses the spam, awesome!
See
formatTributeMessageinmessages.js.