Opened 7 years ago

Closed 7 years ago

Last modified 6 years ago

#4369 closed enhancement (fixed)

[PATCH] Force ready gamesetup button

Reported by: elexis Owned by: Imarok
Priority: Nice to Have Milestone: Alpha 22
Component: UI & Simulation Keywords: patch
Cc: ffm Patch:

Description

Multiplayer games with more than 10 clients take a considerable amount of effort and chat to setup.

Some players do not care about the gamesettings but accept all terms and conditions to play, thus become annoyed by having to click ready repeatedly or otherwise being forced to follow the chat.

There could be a new "Stay ready" button in the gamesetup that is only visible or enabled if the "I'm ready" button is clicked.

Attachments (2)

4369_stay_ready.patch (3.8 KB ) - added by Imarok 7 years ago.
Add third state "Stay Ready"
4369_stay_ready_v2.patch (3.8 KB ) - added by Imarok 7 years ago.
Replace nested ternaries with arrays

Download all attachments as: .zip

Change History (9)

comment:1 by Imarok, 7 years ago

Another way could be to use the I'm ready button, as a tristate button: first click: player gets ready -> second click: player stays ready -> third click: player isn't ready anymore

comment:2 by elexis, 7 years ago

Also suggested by ffm: a countdown of 3 seconds before starting the game, to give the player a chance to react. That would require network protocol changes though.

by Imarok, 7 years ago

Attachment: 4369_stay_ready.patch added

Add third state "Stay Ready"

comment:3 by Imarok, 7 years ago

Keywords: patch review added
Milestone: BacklogAlpha 22
Summary: Force ready gamesetup button[PATCH] Force ready gamesetup button

comment:4 by Vladislav Belov, 7 years ago

Too many ternary, use:

button.caption = [translate("I'm not ready!"), translate("Stay ready"), translate("I'm ready")][g_IsReady];

instead of:

button.caption = g_IsReady ? (g_IsReady == 2 ?  translate("I'm not ready!") :  translate("Stay ready")) : translate("I'm ready"); 
Last edited 7 years ago by Vladislav Belov (previous) (diff)

by Imarok, 7 years ago

Attachment: 4369_stay_ready_v2.patch added

Replace nested ternaries with arrays

comment:5 by Imarok, 7 years ago

Keywords: review removed

comment:6 by Imarok, 7 years ago

Owner: set to Imarok
Resolution: fixed
Status: newclosed

In 19216:

Stay ready button

Reviewed by: elexis
Differential Revision: https://code.wildfiregames.com/D49
Fixes #4369.

comment:7 by elexis, 6 years ago

In 21873:

Allow players to instantly reset the readystate by rightclicking on the ready button, refs #4369, D49 / rP19216.

Note: See TracTickets for help on using tickets.