#5322 closed defect (fixed)
Object orientation gamesetup rewrite
Reported by: | elexis | Owned by: | elexis |
---|---|---|---|
Priority: | Must Have | Milestone: | Alpha 24 |
Component: | UI – Game setup | Keywords: | |
Cc: | Krinkle | Patch: | Phab:D2483 |
Description
#3994 / r19504 / Phab:D322 has unified all gamesetup dropdowns, checkboxes and some miscellaneous GUI objects.
There are still about 1900 lines of code that are in procedural style and use global variables where they could use local variables.
This will be the precondition for future work on the gamesetup, for intsance:
- sliders in the gamesetup (for example ceasefire duration)
- map specific gamesetup options #4838 (for example day/night variant on danubius or water-level-rise-time on extinct volcano)
- anything
It will also make it more obvious to gamesetup developer that procedural code is not the right way to keep this massive GUI page grouped by logic.
Change History (13)
comment:1 by , 6 years ago
comment:2 by , 5 years ago
Component: | UI & Simulation → Game setup |
---|
Seems like that flew under my radar.
comment:3 by , 5 years ago
Cc: | added |
---|
comment:9 by , 5 years ago
The XmppClient and NetClient GUI message handlers can be called from C++ rather than by pulling in onTick
: #5585.
comment:10 by , 4 years ago
Milestone: | Backlog → Alpha 24 |
---|---|
Owner: | set to |
(Started Nov 28th after having idled Nov 27th, refs https://code.wildfiregames.com/D2445#102076)
comment:11 by , 4 years ago
Patch: | → Phab:D2483 |
---|
In r21882:
Gamesetup cleanup.
Move civInfo press event handling from XML to the JS GUI object data from rP19504 / D322. Equally move civInfo tooltip from init (which should remain agnostic of content) following rP21339 / D846, refs #4970.