Opened 5 years ago
Closed 5 years ago
#5345 closed defect (fixed)
An extra argument is passed to Array.shift
Reported by: | False Vision | Owned by: | FeXoR |
---|---|---|---|
Priority: | Should Have | Milestone: | Alpha 24 |
Component: | Maps | Keywords: | patch |
Cc: | FeXoR | Patch: | Phab:D1675 |
Description
A am reading the source code for a while now.
I found out in
"\data\mods\public\maps\random\rmgen\math.js"
Line 140 where there is
pointsToAdd.shift(i);
The argument is extra as Array.shift does not accept any args.
https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/Array/shift
Attachments (1)
Change History (7)
by , 5 years ago
Attachment: | shortest_cycle-excess_argument.diff added |
---|
comment:1 by , 5 years ago
Cc: | added |
---|---|
Keywords: | patch added |
comment:2 by , 5 years ago
Owner: | set to |
---|---|
Status: | new → assigned |
comment:3 by , 5 years ago
comment:4 by , 5 years ago
Patch: | → D1675 |
---|
comment:5 by , 5 years ago
Milestone: | Backlog → Alpha 24 |
---|---|
Patch: | D1675 → Phab:D1675 |
(So much bureaucracy for one character)
Note:
See TracTickets
for help on using tickets.
On Phabricator: https://code.wildfiregames.com/D1675