Opened 5 years ago

Closed 5 years ago

#5345 closed defect (fixed)

An extra argument is passed to Array.shift

Reported by: False Vision Owned by: FeXoR
Priority: Should Have Milestone: Alpha 24
Component: Maps Keywords: patch
Cc: FeXoR Patch: Phab:D1675

Description

A am reading the source code for a while now.

I found out in

"\data\mods\public\maps\random\rmgen\math.js"

Line 140 where there is

pointsToAdd.shift(i);

The argument is extra as Array.shift does not accept any args.

https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/Array/shift

Attachments (1)

shortest_cycle-excess_argument.diff (627 bytes ) - added by FeXoR 5 years ago.

Download all attachments as: .zip

Change History (7)

comment:1 by FeXoR, 5 years ago

Cc: FeXoR added
Keywords: patch added

comment:2 by FeXoR, 5 years ago

Owner: set to FeXoR
Status: newassigned

comment:4 by smiley, 5 years ago

Patch: D1675

comment:5 by elexis, 5 years ago

Milestone: BacklogAlpha 24
Patch: D1675Phab:D1675

(So much bureaucracy for one character)

comment:6 by FeXoR, 5 years ago

Resolution: fixed
Status: assignedclosed

In 22028:

Remove excess argument from shift call

Fixes #5345

Author: FeXoR
Reviewed by: elexis, smiley

Differential Revision: https://code.wildfiregames.com/D1675

Note: See TracTickets for help on using tickets.