Opened 5 years ago

Closed 4 years ago

#5379 closed task (fixed)

Drop Visual Studio 2013

Reported by: Itms Owned by: Itms
Priority: Nice to Have Milestone: Alpha 24
Component: Build & Packages Keywords:
Cc: Patch:

Description (last modified by Itms)

This is mainly a ticket to remind myself of some things.

We now support Visual Studio 2015 in a stable way. 2013 support should be dropped because of its limited modern C++ support, and because it cannot be installed easily anymore (download sources are difficult to find).

Prior to dropping:

  • Commit redistributables for 2015 for players who don't have them installed
  • Make Jenkins build with 2015 instead of 2013
  • Commit glooxwrapper
  • Watch for bugs
  • Resolve #5527

Dropping:

  • Update premake scripts and update-workspaces.bat

After dropping:

To be considered:

  • Add support for 2017 and 2019. Easy to do in premake, but depends on whether whatever version of SpiderMonkey we use can be built with those.

Change History (19)

comment:1 by Itms, 5 years ago

Description: modified (diff)

Found another TODO.

comment:2 by Stan, 5 years ago

Remember I tested on the train back to Paris and that Fcollada doesn't work when built with Vs2015.

comment:3 by hawara, 5 years ago

will this community fork of FCOLLADA work? it has numerous fixes for newer compilers

https://github.com/rdb/fcollada

comment:4 by Stan, 5 years ago

All those fixes are waiting on Phabricator. :)

comment:5 by Vladislav Belov, 5 years ago

I used our feedback and list of Windows versions and I got:

Windows XP: 0.13%

Windows Vista: 0.12%

Windows 7: 17.95%

Windows 8: 0.94%

Windows 8.1+: 80.86%

Last edited 5 years ago by Vladislav Belov (previous) (diff)

comment:6 by Itms, 5 years ago

Description: modified (diff)

The autobuilder now uses VS 2015. I forgot to commit the redistributables (I'll use the opportunity to delete the ones for VS 2011), so users who use SVN and don't have MSVC 2015 redistributables installed (unlikely) will have issues until I do it.

comment:7 by Itms, 5 years ago

In 22338:

Version and update the Windows autobuilder script, refs #5379.

Patch by Angen, based on the previous bat script for the autobuilder job.
Comments by Stan.
Differential Revision: https://code.wildfiregames.com/D1909

comment:8 by Itms, 5 years ago

In 22348:

Delete old redistributables for VS 2010, and add new ones for VS 2015. Refs #5379.

comment:9 by Itms, 5 years ago

Description: modified (diff)

comment:10 by Itms, 5 years ago

In 22406:

Update precompiled win32 libogg to 1.3.3 and libvorbis to 1.3.6, building them with VS2015, refs #5379.

Use the default naming for both libraries (libvorbis instead of vorbis), and use our default suffix for debug versions of the libs.

comment:11 by Itms, 5 years ago

Description: modified (diff)

comment:12 by elexis, 5 years ago

glooxwrapper.h says "We want to let people build the game on Windows with any compiler version (VC2008, 2010, 2012, 2013, and debug vs release)".

comment:13 by Silier, 5 years ago

In [22501]: Update win32 wxWidgets README for VS 2015

comment:14 by historic_bruno, 5 years ago

Description: modified (diff)

comment:15 by elexis, 5 years ago

VS2013 support was broken by r22511 using an array operation that doesn't work in VS2013, see #5539.

comment:16 by Itms, 5 years ago

Description: modified (diff)

I forgot to comment on rP22511 when I got back! But I agree it's better to drop 2013 now, especially since I enabled patch testing on VS2015 on Jenkins.

I'll move forward with #5527 and then do this.

comment:17 by Itms, 4 years ago

In 23305:

Upgrade NVTT to version 2.1.1, fixes #4549.

Windows binaries built with toolset v140_xp.
Tested under Windows, Linux and macOS.
Includes a patch for building on musl Linux, contributed by voroskoi, containing code by leper.
Use the opportunity to set native line endings in the NVTT bundle.

The NVTT DLL was the last one built with VS 2010, refs #5379, #5527.

Differential Revision: https://code.wildfiregames.com/D2475

comment:18 by Itms, 4 years ago

In 23381:

Commit concrt140.dll, dependency of the new NVTT dll. Fixes #5527, refs #4549 and #5379.

comment:19 by Itms, 4 years ago

Resolution: fixed
Status: assignedclosed

In 23382:

Officially drop support for Visual Studio 2013, which stopped working after r22511, fixes #5379.

Note: See TracTickets for help on using tickets.