Opened 5 years ago
Closed 5 years ago
#5442 closed defect (fixed)
Don't add GUI object type specific functions to JSInterface_IGUIObject
Reported by: | elexis | Owned by: | |
---|---|---|---|
Priority: | Should Have | Milestone: | Alpha 24 |
Component: | Core engine | Keywords: | |
Cc: | Patch: | Phab:D2136 |
Description
- r22134 adds a
getTextSize
function to every GUI object type that works for 6 GUI object types and not for the other 6 - Phab:D1781 proposes to add an
addItem
to every GUI object type that only works for one of the GUI object types and not for any other - Phab:D1751 proposes to add an method to every GUI object type that only works for one GUI object type and not for any other
But such GUI object type specific functions should be defined in a function specific to the affected object types, see the tirades in the references.
Change History (4)
comment:1 by , 5 years ago
Milestone: | Backlog → Alpha 24 |
---|---|
Patch: | → Phab:D2136 |
comment:2 by , 5 years ago
comment:4 by , 5 years ago
Resolution: | → fixed |
---|---|
Status: | new → closed |
Fixed, since the other patches were not committed.
Note:
See TracTickets
for help on using tickets.
In 22593: