Ticket #549 (closed enhancement: fixed)

Opened 3 years ago

Last modified 3 years ago

Allow units to be moved by right-clicking on the mini-map

Reported by: evans Owned by:
Priority: Nice to Have Milestone:
Component: Core engine Keywords: review
Cc:

Description

Units can be ordered to move to a certain place by right clicking on the mini-map.

Attachments

rightClickMinimap.patch (9.7 KB) - added by Badmadblacksad 3 years ago.

Change History

Changed 3 years ago by Badmadblacksad

comment:1 Changed 3 years ago by Badmadblacksad

  • Keywords review added

Hi, that's my second attempt to submit a patch.. not sure it worth something. any feedback would be appreciated. In the way I coded it, right clicking on the minimap allows us to move units or to set a rallypoint.

comment:2 Changed 3 years ago by feneur

I'm sure it's worth something. I'll leave it to Philip to decide whether it can be integrated immediately or needs some more work, but it's going to be nice to have that behavior in the game. Thanks for the patch, you may have to wait up to a week or so before Philip has time to look at it, but in the mean time feel free to start working at another ticket. (If you have got no answer in a week, then I'm sure Philip won't mind you giving him a reminder.)

comment:3 Changed 3 years ago by Philip

Thanks, this seems to work well. The method of getting messages from the GUI object to the scripts is a bit unpleasantly complex and inflexible - I've changed it to use IGUIObject::ScriptEvent instead, and extended that to support passing an arbitrary argument to the script, to avoid special-casing these minimap events. Also changed some whitespace to be a bit more consistent. Otherwise it seems fine.

comment:4 Changed 3 years ago by philip

  • Status changed from new to closed
  • Resolution set to fixed

(In [8107]) Fix #549 (Allow units to be moved by right-clicking on the mini-map), based on patch from Badmadblacksad

comment:5 Changed 3 years ago by anonymous

  • Milestone Unclassified deleted

Milestone Unclassified deleted

Note: See TracTickets for help on using tickets.