Opened 4 years ago

Closed 3 years ago

Last modified 3 years ago

#5635 closed defect (fixed)

Crash in non-GLSL mode when gpuskinning is enabled

Reported by: Stan Owned by: Silier
Priority: Should Have Milestone: Alpha 24
Component: Core engine Keywords:
Cc: Vladislav Belov Patch: Phab:D2423

Description

If one adds in their user.cfg the line

    gpuskinning = "true"

and then tries to disable GLSL the game will crash.

That's because ARB does not support VertexAttribPointer. One lazy solution is to check for that in the RenderModel() and PrepareModelDef() functions in InstancingModelRenderer.cpp and anywhere else it's called.

Also one might not notice the lack of support because in ShaderProgram.cpp debug_warn() instead of LOGGERROR() are used so it doesn't show up in the interestinglog.html file. This could be fixed as well

Change History (3)

comment:1 by Silier, 4 years ago

Milestone: BacklogWork In Progress
Owner: set to Silier
Patch: Phab:D2423

comment:2 by Silier, 3 years ago

Resolution: fixed
Status: newclosed

In 24101:

Do not use GPUSkinning without glsl [Crash fix]

Disable GPUSkinning when glsl is disabled, because VertexAttribPointer is not implemented on ARB/GLES and it is called by GPUSkinning.

Differential Revision: D2423
Reviewed by: vladislavbelov
Fixes: #5635

comment:3 by Silier, 3 years ago

Milestone: Work In ProgressAlpha 24
Note: See TracTickets for help on using tickets.