Opened 4 years ago

Closed 4 years ago

Last modified 4 years ago

#5668 closed defect (fixed)

Missing cmpTechnologyManager check in Commands.js

Reported by: Silier Owned by: Silier
Priority: Should Have Milestone: Alpha 24
Component: Simulation Keywords: simple
Cc: Patch: Phab:D2632

Description

In components/helpers/Commands.js when upgrade command is passed, there is missing check for cmpTechnologyManager existence, which does not exist for all players (currently gaia player, but can be more).

This can lead to error of undefined component and should be fixed. Putting at lower priority, because GUI is patched against this problem.

Change History (5)

comment:1 by Silier, 4 years ago

Component: Core engineSimulation

dummy me

comment:2 by Antonio, 4 years ago

Pre-commit posted.

comment:3 by Silier, 4 years ago

Milestone: Alpha 24Work In Progress
Patch: Phab:D2632

comment:4 by Silier, 4 years ago

Owner: set to Silier
Resolution: fixed
Status: newclosed

In 23500:

Fix missing cmpTechnologyManager check in Commands.js

Check for cmpTechnologyManager existence to avoid calling function on null when upgrading entity requires some technology to be researched.

Differential Revision: https://code.wildfiregames.com/D2632
Fixes: #5668
Patch by: @Ampaex

comment:5 by Silier, 4 years ago

Milestone: Work In ProgressAlpha 24
Note: See TracTickets for help on using tickets.