Rewrite Hotkey's Implementation

[Sergey]

Hotkey system needs to be totally reviewed. The main thing to correct is to reduce confusing things like defining hotkeys in Hotkey.cpp and Hotkey.h. They won't work until a new string is added to default.cfg. Some other notes will be added during the process of enhancement.

[(none)]

Milestone Alpha deleted

[fabio]

(See also duplicates #618 and #627)

[philip]

(In [8444]) # Fix hotkey bugs. Simplify hotkey system to use strings consistently. Restrict scope of GUI hotkey bindings to the associated page. Avoid hard-coding list of hotkeys. Clean up the code a little bit and fix some bugs. Remove unused "!" prefix for key negation. Fixes #567.

[Erik Johansson]

What's the status of the list of hotkeys in Default.cfg? There seems to be a lot of unused ones etc.

In either case, hotkeys should preferably be modifiable via GUI, and hopefully that shouldn't be too difficult to add?

[fabio]

I want to report a minor issue: when pressing ALT+W it shows the wireframe mode but map also moves a little forward (as one would have pressed W). Apparently ALT+W match to two keymappings, not a big issue with this specific key, but it may cause other problems in future with other keymappings.

[Erik Johansson]

True, key combinations shouldn't be understood as the single keys on their own + together, but only as the keys together. I'm going to reopen this ticket as that's a major bug with the system. Especially since it effectively makes modifier keys useless.

[Philip Taylor]

(I think it would have been better to open new tickets for these new issues, rather than adding them onto the end of a ticket that has already been completed and closed, so that it's harder to miss the new issues and easier to track their progress individually.)

r8546 cleans up default.cfg and fixes alt+w.

[elexis]

In 22845:

Implement JS support for GUI object "hotkey" setting missing from rP804, refs #567, #2604, rP8444.

Allows JS GUI to assign hotkeys to GUI objects from JS instead of XML.

Differential Revision: ​https://code.wildfiregames.com/D2257
Comments By: nani
Tested By: nani, Jenkins
Tested on: clang, VS2015