Ticket #567 (closed enhancement: fixed)

Opened 3 years ago

Last modified 3 years ago

Rewrite Hotkey's Implementation

Reported by: markelov Owned by: Philip
Priority: Must Have Milestone: Alpha 3
Component: Core engine Keywords: hotkey shortcut
Cc:

Description

Hotkey system needs to be totally reviewed. The main thing to correct is to reduce confusing things like defining hotkeys in Hotkey.cpp and Hotkey.h. They won't work until a new string is added to default.cfg. Some other notes will be added during the process of enhancement.

Change History

comment:1 Changed 3 years ago by anonymous

  • Milestone Alpha deleted

Milestone Alpha deleted

comment:2 Changed 3 years ago by wacko

  • Milestone set to Backlog

comment:3 Changed 3 years ago by k776

  • Priority changed from minor to critical
  • Milestone changed from Backlog to Alpha 3

comment:4 Changed 3 years ago by k776

  • Summary changed from hotkey enhacments to Rewrite Hotkey's Implementation

comment:5 Changed 3 years ago by wacko

  • Owner changed from markelov to wacko

comment:6 Changed 3 years ago by fabio

(See also duplicates #618 and #627)

comment:7 Changed 3 years ago by k776

  • Owner changed from wacko to Philip

comment:8 Changed 3 years ago by philip

  • Status changed from new to closed
  • Resolution set to fixed

(In [8444]) # Fix hotkey bugs. Simplify hotkey system to use strings consistently. Restrict scope of GUI hotkey bindings to the associated page. Avoid hard-coding list of hotkeys. Clean up the code a little bit and fix some bugs. Remove unused "!" prefix for key negation. Fixes #567.

comment:9 Changed 3 years ago by feneur

What's the status of the list of hotkeys in Default.cfg? There seems to be a lot of unused ones etc.

In either case, hotkeys should preferably be modifiable via GUI, and hopefully that shouldn't be too difficult to add?

comment:10 Changed 3 years ago by fabio

I want to report a minor issue: when pressing ALT+W it shows the wireframe mode but map also moves a little forward (as one would have pressed W). Apparently ALT+W match to two keymappings, not a big issue with this specific key, but it may cause other problems in future with other keymappings.

comment:11 Changed 3 years ago by feneur

  • Status changed from closed to reopened
  • Resolution fixed deleted

True, key combinations shouldn't be understood as the single keys on their own + together, but only as the keys together. I'm going to reopen this ticket as that's a major bug with the system. Especially since it effectively makes modifier keys useless.

comment:12 Changed 3 years ago by Philip

  • Status changed from reopened to closed
  • Resolution set to fixed

(I think it would have been better to open new tickets for these new issues, rather than adding them onto the end of a ticket that has already been completed and closed, so that it's harder to miss the new issues and easier to track their progress individually.)

r8546 cleans up default.cfg and fixes alt+w.

Note: See TracTickets for help on using tickets.