Opened 4 years ago

Closed 3 years ago

Last modified 3 years ago

#5694 closed task (fixed)

Stop using Python 2 in 0 A.D.

Reported by: Guido Falsi Owned by: Itms
Priority: Must Have Milestone: Alpha 24
Component: Core engine Keywords:
Cc: Patch: Phab:D2501, Phab:D2757

Description (last modified by wraitii)

This is a general ticket for the "Python 2 EOL" release blocker.

Tasks:

Distributions now expect python2 or python3.

Change History (14)

comment:1 by asterix, 4 years ago

Keywords: Spidermonkey Python added
Milestone: BacklogAlpha 24
Priority: Should HaveRelease Blocker
Type: enhancementtask

Hi, thank you for the heads up some of us are already aware of this. There is already work going in that direction such as https://code.wildfiregames.com/D506 and https://code.wildfiregames.com/D2501 (the previous commit that introduced previous version is this https://code.wildfiregames.com/rP9417 but please keep in mind that spidermonkey version will still be upgraded as seen here https://trac.wildfiregames.com/changeset/22627 https://trac.wildfiregames.com/ticket/4893

comment:2 by Ludovic Rousseau, 4 years ago

For the same reason 0ad is (will be in 10 hours) removed from Debian testing.

See https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=967118

comment:3 by Stan, 4 years ago

Thanks for letting us know. Sorry about the delay.

comment:4 by wraitii, 3 years ago

Description: modified (diff)
Patch: Phab:D2501, Phab:D2757
Summary: EmMbedded spidermonkey depends on python 2.7 for buildStop using Python 2 in 0 A.D.

(Hijacking this ticket as the main Python3 ticket).

comment:5 by chris, 3 years ago

Removed from gentoo too :

- games-strategy/0ad-0.0.23b_alpha::gentoo (masked by: package.mask)
/usr/portage/profiles/package.mask:
# MichaŠGórny <mgorny@gentoo.org> (2020-09-09)
# These packages (or package versions) still require Python 2.7.
# They are either dead upstream, their Python 3 porting efforts are
# not progressing or their maintainers are simply unresponsive.
# Please do not remove any packages from this list unless you actually
# port them to Python 3.
# Removal in 30 days.  Please find relevant bugs on tracker bug #694800.

comment:6 by Stan, 3 years ago

Description: modified (diff)

Thanks for the report :(

comment:7 by wraitii, 3 years ago

In 24282:

Fix MacOs bundle for Python3

Update the lib used to handle plists, as dmgbuild changed things for Python3.

Refs #5694

Differential Revision: https://code.wildfiregames.com/D3157

comment:8 by wraitii, 3 years ago

In 24313:

Update i18n scripts to run on Python3

The pology library runs on Python2 and development appears stalled. It is also not available on pip.
The babel library, BSD-licensed, provides, amongst many other things, a replacement for .POT / .PO manipulation.

The poediff tool that we used to detect spurious i18n change is replaced with a Python script that does a simpler but good enough job (it is also much, much faster).

These replacements let the i18n scripts run on Python3 entirely.

Makes D506 redundant.

Comments by: Itms

Reviewed By: Gallaecio

Refs #5694

Differential Revision: https://code.wildfiregames.com/D2757

comment:9 by wraitii, 3 years ago

In 24332:

[SM78 1/2] Upgrade Spidermonkey build system and binaries to 78.6.0

SM78 drops usage of Python 2 in favour of Python 3.

SM78 is the first ESR to actually use rust, which means a new static library is bundled.
This means LLVM-objdump is now a dependency of Spidermonkey, and also 0 A.D.

SM78 also removes the need for NSPR on Windows (Bug 1556646).

Tested by: Stan, Freagarach, mammadori

Refs #5694
Refs #5861

Differential Revision: https://code.wildfiregames.com/D3167

comment:10 by Silier, 3 years ago

Description: modified (diff)

comment:11 by wraitii, 3 years ago

Description: modified (diff)
Priority: Release BlockerMust Have

No longer a release blocker after Phab:rP24376 upgraded cxxtest.

comment:12 by wraitii, 3 years ago

Milestone: Alpha 24Alpha 25

Rest of the ticket is pushed back.

comment:13 by Itms, 3 years ago

Owner: set to Itms
Resolution: fixed
Status: newclosed

In 24892:

Port remaining python2 helper scripts to python3, fixes #5694.

Differential Revision: https://code.wildfiregames.com/D2501

comment:14 by Itms, 3 years ago

Keywords: Spidermonkey Python removed
Milestone: Alpha 25Alpha 24
Note: See TracTickets for help on using tickets.