Opened 4 years ago
Closed 4 years ago
#5788 closed defect (fixed)
Gathering/hunting infinite loop r23796
| Reported by: | Silier | Owned by: | wraitii |
|---|---|---|---|
| Priority: | Release Blocker | Milestone: | Alpha 24 |
| Component: | Simulation | Keywords: | |
| Cc: | wraitii | Patch: | Phab:D2920 |
Description
Reported on forums https://wildfiregames.com/forum/index.php?/topic/28468-crash-to-desktop-vs-ai-on-rev-23796/ Youtube video: https://www.youtube.com/watch?v=fV5MZ7aBS5Q&feature=youtu.be&t=2302
It is similar to infinite loop in unitai.
Attachments (1)
Change History (9)
by , 4 years ago
| Attachment: | commands.txt added |
|---|
comment:1 by , 4 years ago
| Summary: | Crash without logs and dumps → Crash without logs and dumps r23796 |
|---|
comment:2 by , 4 years ago
| Owner: | set to |
|---|
comment:3 by , 4 years ago
| Cc: | added |
|---|---|
| Owner: | removed |
We have here infinite loop indeed.
wraitii not sure which commit did it, but I think you touched code around hunt and gathering mostly, could you investigate, I am a bit lost in its maze, I believe you have better understanding of that part.
if (this.log)
warn(this.entity + " -> new state");
if (this.CheckTargetRange(this.order.data.target, IID_ResourceGatherer))
this.SetNextState("INDIVIDUAL.GATHER.GATHERING");
else
this.SetNextState("INDIVIDUAL.GATHER.APPROACHING");
WARNING: 7941 FINDINGNEWTARGET.enter WARNING: 7941 Order.Gather WARNING: 7941 -> new state WARNING: 7941 FINDINGNEWTARGET.leave WARNING: 7941 FINDINGNEWTARGET.enter WARNING: 7941 Order.Gather WARNING: 7941 -> new state WARNING: 7941 FINDINGNEWTARGET.leave WARNING: 7941 FINDINGNEWTARGET.enter WARNING: 7941 Order.Gather WARNING: 7941 -> new state WARNING: 7941 FINDINGNEWTARGET.leave WARNING: 7941 FINDINGNEWTARGET.enter WARNING: 7941 Order.Gather WARNING: 7941 -> new state WARNING: 7941 FINDINGNEWTARGET.leave WARNING: 7941 FINDINGNEWTARGET.enter WARNING: 7941 Order.Gather WARNING: 7941 -> new state WARNING: 7941 FINDINGNEWTARGET.leave WARNING: 7941 FINDINGNEWTARGET.enter WARNING: 7941 Order.Gather WARNING: 7941 -> new state WARNING: 7941 FINDINGNEWTARGET.leave WARNING: 7941 FINDINGNEWTARGET.enter WARNING: 7941 Order.Gather WARNING: 7941 -> new state WARNING: 7941 FINDINGNEWTARGET.leave WARNING: 7941 FINDINGNEWTARGET.enter WARNING: 7941 Order.Gather WARNING: 7941 -> new state WARNING: 7941 FINDINGNEWTARGET.leave WARNING: 7941 FINDINGNEWTARGET.enter WARNING: 7941 Order.Gather WARNING: 7941 -> new state WARNING: 7941 FINDINGNEWTARGET.leave WARNING: 7941 FINDINGNEWTARGET.enter WARNING: 7941 Order.Gather WARNING: 7941 -> new state WARNING: 7941 FINDINGNEWTARGET.leave WARNING: 7941 FINDINGNEWTARGET.enter
comment:4 by , 4 years ago
| Summary: | Crash without logs and dumps r23796 → Gathering/hunting infinite loop r23796 |
|---|
comment:6 by , 4 years ago
Thanks for the investigation, I'm taking over, should be relatively straightforward to fix with a replay.
The obvious suspect is Phab:rP23742, but that diff is conceptually correct so this likely means that we're using different checks in different places.
comment:7 by , 4 years ago
| Owner: | set to |
|---|---|
| Patch: | → Phab:D2920 |
replay