Opened 3 years ago

Closed 16 months ago

Last modified 16 months ago

#5986 closed task (fixed)

Upgrade 0 A.D. to Spidermonkey ESR 91

Reported by: wraitii Owned by: wraitii
Priority: Must Have Milestone: Alpha 27
Component: Core engine Keywords:
Cc: Patch:

Description

Firefox 91, the next ESR, is planned to come out in July.

Setting up this ticket to log stuff in advance.

Potentially interesting: https://hg.mozilla.org/mozilla-central/rev/7c1dcab226105b4d4dab172021483381689dd6d7 (I had trouble with that and ultimately reverted to non-incremental GC)

Expect performance improvements this time around (see work on new Baseline interpreter)

Change History (9)

comment:1 by Arfrever Frehtes Taifersar Arahesis, 3 years ago

Commits related to Mozilla bug 1681268 were backported to ESR 78 branch:

https://hg.mozilla.org/releases/mozilla-esr78/rev/9fad778aa3291ef630338bc568453a79faa37089

https://hg.mozilla.org/releases/mozilla-esr78/rev/488097780e542ac1379b35c473ac5c06892810e1

And are included in SpiderMonkey 78.7.0 release.

Please firstly update SpiderMonkey used by 0 A.D. from 78.6.0 to 78.7.0.

comment:2 by Freagarach, 3 years ago

Milestone: Alpha 25Alpha 26

Not happening before the release.

comment:3 by Freagarach, 2 years ago

Owner: set to wraitii

comment:4 by wraitii, 2 years ago

In 26205:

Remove JS_New in favour of JS::Construct in preparation for SM91

Spidermonkey 91, the next ESR, removes JS_New in favour or JS::Construct.
See
https://github.com/mozilla-spidermonkey/spidermonkey-embedding-examples/blob/migration-guide/docs/Migration%20Guide.md#object-construction
and
https://bugzilla.mozilla.org/show_bug.cgi?id=1491055

This change is SM78 compatible and therefore done beforehand.

Tested by: Freagarach

Refs #5986

Differential Revision: https://code.wildfiregames.com/D4427

comment:5 by Stan, 2 years ago

Milestone: Alpha 26Alpha 27

Unlikely to get done for A26

comment:6 by jprahman, 21 months ago

ESR102 is out, may be worth looking into upgrading to ESR102 instead of ESR91 for the additional improvements in 102

comment:7 by Freagarach, 16 months ago

Milestone: Alpha 27Backlog

Pushing back.

comment:8 by Stan, 16 months ago

Resolution: fixed
Status: newclosed

In 27409:

[SM91] Update to Spidermonkey 91.1.3 APIs
Fixes: #5986
Patch by: @wraitii
Comments by: @nwtour, @Stan

Differential Revision: https://code.wildfiregames.com/D4428

comment:9 by Stan, 16 months ago

Milestone: BacklogAlpha 27
Note: See TracTickets for help on using tickets.