Opened 2 years ago

Closed 21 months ago

Last modified 21 months ago

#6390 closed defect (fixed)

playerPlacementRiver function doesn't place teams properly in some cases

Reported by: Andy Alt Owned by: marder
Priority: Should Have Milestone: Alpha 26
Component: Maps Keywords:
Cc: Patch: Phab:D4747

Description

playerPlacementRiver function doesn't place teams properly in some cases. For example, when setting up the random map Corinthian Isthmus, in a 7-player game, if the first 3 players are on Team 1, and the last 4 are on team 2, player 4 (counting top to bottom in the player list from the setup menu) will be on the side of the river where the 3 players on T1 are placed.

In a 5-player game, if the first 2 players are on T1 and the other 3 are on T2, player 3 will be placed with T1.

Change History (6)

comment:1 by Freagarach, 2 years ago

Component: UI & SimulationMaps
Priority: Must HaveShould Have

comment:2 by Freagarach, 2 years ago

Milestone: Alpha 26Backlog

comment:3 by Andy Alt, 22 months ago

Milestone: BacklogAlpha 27

comment:4 by marder, 21 months ago

Patch: Phab:D4747

comment:5 by marder, 21 months ago

Owner: set to marder
Resolution: fixed
Status: newclosed

In 27039:

[maps] Adjust playerPlacementRiver to group teams on the same side in most cases

Brute forcing the right arrangement, which is unnecessary but accepted since it has only a negligible performance impact overall.

accepted by: @lyv @andy5995

Fixes: #6390

Differential revision: https://code.wildfiregames.com/D4747

comment:6 by marder, 21 months ago

Milestone: Alpha 27Alpha 26
Note: See TracTickets for help on using tickets.