Include list of unused data json files in checkrefs.py

[Langbart]

Having fewer files to translate is good. To find unused files automatically, it should be integrated into the python script checkrefs.py.

Aura

Name	Removed from template with	Removed from the Game
​structures/rotary_mill	[25561]	[26900]
​units/han_minister_cost	unused in the main game	[26900]
​units/elephant_worker	[26898]	[26900]
​han_hero_wei_qing_3.json	[26980]	[26992]

Technologies

Name	Removed from template with	Removed from the Game
​upgrade_rank_advanced_crossbow	unused in the main game	[26900]
​upgrade_rank_elite_crossbow	unused in the main game	[26900]
​pair_unlock_arrows_type	[26469]	[26900]

shell function

used for finding unlisted data json files in the simulation folder

function unusedJSON {
  CURRENT_DIR=$(pwd)
  cd ~/0ad/binaries/data/mods/public/simulation/data/auras || return 1
  printf "\e[1;97mList unused Auras:\e[0m\n"
  for a in $(find . -name "*.json" | sed 's|./||;s|.json||'); do
    if [[ $(grep --include=\*.xml -rw ~/0ad/binaries/data/mods/public/simulation -e "$a" | wc -c) -eq 0 ]]; then
      echo "$a"
    fi
  done
  cd ~/0ad/binaries/data/mods/public/simulation/data/technologies || return 1
  printf "\e[1;97m\nList unused Technologies:\e[0m\n"
  for t in $(find . -name "*.json" | xargs grep -Le 'autoResearch.*true' | sed 's|./||;s|.json||'); do
    if [[ $(grep --include={*.xml,test_Researcher.js,pair_unlock*.json} -rw ~/0ad/binaries/data/mods/public/simulation -e "$t" | wc -c) -eq 0 ]]; then
      echo "$t"
    fi
  done
  cd "${CURRENT_DIR}" || return 1
}

related tickets

• #3800 (4/Mar/16)

[Stan]

Nice findings. I suppose they should be reported by checkrefs -u

[marder]

In 26900:

Delete some unused techs/ auras

detected by @Langbart
Fixes #6544

Differential revision: ​https://code.wildfiregames.com/D4663

[Langbart]

• Adding a new unused json file from [26980]
• The ticket should only be closed if the checkrefs.py script can find these files.

[Stan]

Nice function, it's not cross-platform though, so I have to rewrite it to be:

• mod compatible
• windows compatible (e.g the CI doesn't care but modders might)

[Langbart]

han_hero_wei_qing_3 moved from the tech to the aura table.

[Stan]

In 26991:

Add techs and auras to the list of possibly missing files.
Refs: #6544
Accepted by: @Langbart
Differential Revision: ​https://code.wildfiregames.com/D4725

[Stan]

In 26992:

Remove unused han_hero_wei_qing_3.json aura.
Reported by: @Langbart
Fixes #6544
Fixes ​Phab:rP26980

[Langbart]

update Aura table