Ticket #875 (closed defect: fixed)

Opened 2 years ago

Last modified 23 months ago

Out of memory errors should work nicer

Reported by: k776 Owned by: historic_bruno
Priority: Should Have Milestone: Alpha 6
Component: Core engine Keywords: scripting,spidermonkey
Cc:

Description

See http://www.wildfiregames.com/forum/index.php?showtopic=14859

We should show them a warning in game about out of memory, not just in the logs.

Change History

comment:1 Changed 2 years ago by historic_bruno

I agree Spidermonkey OOM errors should be handled better (see #742), but it's actually more complicated than it sounds. The normal way of handling SM errors won't work because OOM errors are designed not to halt the script but to let it keep running. I don't see that being solved for A6 and maybe should wait for SM to be upgraded anyway before we mess too much with its internals.

In the short term, we should ensure OOM errors don't occur in normal operation, probably by increasing the script runtime size for the map generator from 96MB to whatever is enough to make it work (although even the simulation scripts will give OOM errors when there's too many trees, for instance).

comment:2 Changed 23 months ago by historic_bruno

That issue was solved in [9664], so this will probably be an A7 ticket at the soonest.

comment:3 Changed 23 months ago by historic_bruno

  • Milestone changed from Alpha 6 to Alpha 7

comment:4 Changed 23 months ago by historic_bruno

  • Keywords scripting,spidermonkey added; rms removed

comment:5 Changed 23 months ago by k776

  • Status changed from new to closed
  • Resolution set to fixed
  • Milestone changed from Alpha 7 to Alpha 6

Fixed in Alpha 6. There might be more issues, but we'll address them as they show up.

Note: See TracTickets for help on using tickets.