Opened 13 years ago

Closed 12 years ago

Last modified 8 years ago

#990 closed enhancement (fixed)

[PATCH] build with system provided libmozjs185

Reported by: infyquest Owned by:
Priority: Should Have Milestone: Alpha 8
Component: Core engine Keywords: patch
Cc: Patch:

Description

This is a build system patch to build with system provided libmozjs185 especially on linux. This helps in removing dependency on building SpiderMonkey on linux.

Attachments (1)

0001-add-with-system-mozjs185-parameter-to-build-system-t.patch​ (4.7 KB ) - added by infyquest 13 years ago.

Download all attachments as: .zip

Change History (6)

by infyquest, 13 years ago

Attachment: 0001-add-with-system-mozjs185-parameter-to-build-system-t.patch​ added

comment:1 by infyquest, 13 years ago

Summary: build with system provided libmozjs185 → [PATCH] build with system provided libmozjs185

this adds new command line parameter --with-system-libmozjs185 to update-workspaces.sh and prebuild4.lua

comment:2 by philip, 12 years ago

Resolution: → fixed
Status: new → closed

(In [10534]) Add --with-system-mozjs185 build flag. Fixes #990, based on patch by infyquest.

comment:3 by Philip Taylor, 12 years ago

I changed the compile_settings part a little to avoid duplicating the includedirs lines. Also tested that the game seems to currently work okay with --enable-threadsafe builds (or at least it doesn't give any assertion failures in debug mode).

I seem to get linker errors when using the libmozjs185-dev package on Ubuntu though, so I'll try to look into that.

comment:4 by philip, 12 years ago

(In [10535]) Fix ABI incompatibility with --with-system-mozjs185 in debug mode (see #990).

comment:5 by sanderd17, 8 years ago

Keywords: review removed
Note: See TracTickets for help on using tickets.