Ticket #3176: no_attack_notification_for_domestic_animals_r16549.diff

binaries/data/mods/public/gui/session/messages.js

@@ -119 +119 @@
         addChatMessage({
             "type": "attack",
             "player": player,
-            "attacker": notification.attacker
+            "attacker": notification.attacker,
+            "target": notification.target
         });
     },
     "dialog": function(notification, player)
@@ -509 +510 @@
             return;
 
         [username, playerColor] = getUsernameAndColor(msg.attacker);
+        var targetEntState = GetExtendedEntityState(msg.target);
+        var targetIdentityClasses = targetEntState.identity.classes;
+        var targetIsDomesticAnimal = targetIdentityClasses.indexOf("Animal") != -1 && targetIdentityClasses.indexOf("Domestic") != -1;
+        // Since livestock can be attacked/gathered by allied players
+        // and generally not so valuable as other units/buildings,
+        // we don't display the attack notification for it
+        if (targetIsDomesticAnimal)
+            return;
         formatted = sprintf(translate("You have been attacked by %(attacker)s!"), { attacker: "[color=\"" + playerColor + "\"]" + username + "[/color]" });
         break;
     case "message":

binaries/data/mods/public/simulation/components/AttackDetection.js

@@ -78 +78 @@
     this.AddSuppression(event);
     Engine.PostMessage(this.entity, MT_AttackDetected, { "player": cmpPlayer.GetPlayerID(), "event": event });
     var cmpGuiInterface = Engine.QueryInterface(SYSTEM_ENTITY, IID_GuiInterface);
-    cmpGuiInterface.PushNotification({"type": "attack", "players": [cmpPlayer.GetPlayerID()], "attacker": cmpAttackerOwnership.GetOwner() });
+    cmpGuiInterface.PushNotification({"type": "attack", "players": [cmpPlayer.GetPlayerID()], "attacker": cmpAttackerOwnership.GetOwner(), "target": target });
     PlaySound("attacked", target);
 };