Ticket #3210: cacheHighlight3.patch

binaries/data/mods/public/gui/session/selection.js

@@ -457 +457 @@
     g_canMoveIntoFormation = {};
     g_allBuildableEntities = undefined;
     g_allTrainableEntities = undefined;
+    g_MenuUpdateCache = {
+        stance: undefined,
+        formation:undefined
+        //queue:undefined todo
+    }
 }
 
 

binaries/data/mods/public/gui/session/selection_panels.js

@@ -34 +34 @@
 
 let g_SelectionPanels = {};
 
+// Keep track of menu highlights before the engine has commited them 
+var g_MenuUpdateCache = {
+    stance: undefined,
+    formation:undefined
+    //queue:undefined todo
+}
+
+
 g_SelectionPanels.Alert = {
     "getMaxNumberOfItems": function()
     {
@@ -374 +382 @@
 
         let formationInfo = g_FormationsInfo.get(data.item);
         let formationOk = canMoveSelectionIntoFormation(data.item);
-        let formationSelected = Engine.GuiInterfaceCall("IsFormationSelected", {
-            "ents": data.selection,
-            "formationTemplate": data.item
-        });
+        data.button.onPress = function() { 
+            g_MenuUpdateCache.formation = data.item;
 
-        data.button.onPress = function() { performFormation(data.unitEntState.id, data.item); };
-
+            performFormation(data.unitEntState.id, data.item); 
+            updateSelectionDetails();
+        };
         let tooltip = translate(formationInfo.name);
         if (!formationOk && formationInfo.tooltip)
             tooltip += "\n" + "[color=\"red\"]" + translate(formationInfo.tooltip) + "[/color]";
@@ -388 +395 @@
 
         data.button.enabled = formationOk && controlsPlayer(data.unitEntState.player);
         let grayscale = formationOk ? "" : "grayscale:";
-        data.guiSelection.hidden = !formationSelected;
+        if(g_MenuUpdateCache.formation){
+            var showHighlight = g_MenuUpdateCache.formation === data.item;
+            data.guiSelection.hidden = !showHighlight
+        } else {
+            data.guiSelection.hidden = !Engine.GuiInterfaceCall("IsFormationSelected", {
+                "ents": data.selection,
+                "formationTemplate": data.item
+            });
+        }
+
         data.icon.sprite = "stretched:" + grayscale + "session/icons/" + formationInfo.icon;
 
         setPanelObjectPosition(data.button, data.i, data.rowLength);
@@ -918 +934 @@
         return true;
     }
 };
-
+ 
 g_SelectionPanels.Stance = {
     "getMaxNumberOfItems": function()
     {
@@ -932 +948 @@
     },
     "setupButton": function(data)
     {
-        data.button.onPress = function() { performStance(data.unitEntState, data.item); };
-
+        data.button.onPress = function() { 
+            g_MenuUpdateCache.stance = data.item
+            updateSelectionDetails();
+            performStance(data.unitEntState, data.item); 
+            
+        };
         data.button.tooltip = getStanceDisplayName(data.item) + "\n" +
             "[font=\"sans-13\"]" + getStanceTooltip(data.item) + "[/font]";
 
-        data.guiSelection.hidden = !Engine.GuiInterfaceCall("IsStanceSelected", {
-            "ents": data.selection,
-            "stance": data.item
-        });
+        if(g_MenuUpdateCache.stance){
+            var showHighlight = g_MenuUpdateCache.stance === data.item;
+            data.guiSelection.hidden = !showHighlight
+        }else {
+            data.guiSelection.hidden =  !Engine.GuiInterfaceCall("IsStanceSelected", {
+                "ents": data.selection,
+                "stance": data.item
+            });
+        }
+        
+        
         data.icon.sprite = "stretched:session/icons/stances/" + data.item + ".png";
         data.button.enabled = controlsPlayer(data.unitEntState.player);